Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-18 Thread chenxiaolong
在 2023-08-18五的 15:19 +0800,Xi Ruoyao写道: > On Fri, 2023-08-18 at 15:05 +0800, Xi Ruoyao via Gcc-patches wrote: > > On Fri, 2023-08-18 at 14:58 +0800, Xi Ruoyao via Gcc-patches wrote: > > > On Fri, 2023-08-18 at 14:39 +0800, chenxiaolong wrote: > > > > 在 2023-08-17四的 15:08 +,Joseph Myers写道: > > >

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-18 Thread Xi Ruoyao via Gcc-patches
On Fri, 2023-08-18 at 15:05 +0800, Xi Ruoyao via Gcc-patches wrote: > On Fri, 2023-08-18 at 14:58 +0800, Xi Ruoyao via Gcc-patches wrote: > > On Fri, 2023-08-18 at 14:39 +0800, chenxiaolong wrote: > > > 在 2023-08-17四的 15:08 +,Joseph Myers写道: > > > > On Thu, 17 Aug 2023, Xi Ruoyao via Gcc-patche

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-18 Thread Xi Ruoyao via Gcc-patches
On Fri, 2023-08-18 at 14:58 +0800, Xi Ruoyao via Gcc-patches wrote: > On Fri, 2023-08-18 at 14:39 +0800, chenxiaolong wrote: > > 在 2023-08-17四的 15:08 +,Joseph Myers写道: > > > On Thu, 17 Aug 2023, Xi Ruoyao via Gcc-patches wrote: > > > > > > > So I guess we just need > > > > > > > > builtin_def

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-17 Thread Xi Ruoyao via Gcc-patches
On Fri, 2023-08-18 at 14:39 +0800, chenxiaolong wrote: > 在 2023-08-17四的 15:08 +,Joseph Myers写道: > > On Thu, 17 Aug 2023, Xi Ruoyao via Gcc-patches wrote: > > > > > So I guess we just need > > > > > > builtin_define ("__builtin_fabsq=__builtin_fabsf128"); > > > builtin_define ("__builtin_nanq=

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-17 Thread chenxiaolong
在 2023-08-17四的 15:08 +,Joseph Myers写道: > On Thu, 17 Aug 2023, Xi Ruoyao via Gcc-patches wrote: > > > So I guess we just need > > > > builtin_define ("__builtin_fabsq=__builtin_fabsf128"); > > builtin_define ("__builtin_nanq=__builtin_nanf128"); > > > > etc. to map the "q" builtins to "f128"

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-17 Thread Joseph Myers
On Thu, 17 Aug 2023, Xi Ruoyao via Gcc-patches wrote: > So I guess we just need > > builtin_define ("__builtin_fabsq=__builtin_fabsf128"); > builtin_define ("__builtin_nanq=__builtin_nanf128"); > > etc. to map the "q" builtins to "f128" builtins if we really need the > "q" builtins. > > Joseph:

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-16 Thread chenxiaolong
Okay, thanks for the heads up! I'll try to format the code according to the GNU Coding Standards. I'll double-check every line of the submitted patch to make sure that I don't have such a low-level formatting problem in every future patch, so that I can comply with the code specification. 在 2023-0

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-16 Thread Xi Ruoyao via Gcc-patches
On Tue, 2023-08-15 at 20:03 +, Joseph Myers wrote: > On Tue, 15 Aug 2023, chenxiaolong wrote: > > > In the implementation process, the "q" suffix function is > >     Re-register and associate the "__float128" type with the > >     "long double" type so that the compiler can han

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-16 Thread Joseph Myers
On Wed, 16 Aug 2023, chenxiaolong wrote: > Thanks for the tip! Similar functions (e.g. __builtin_fabsf128 > (_Float128 a) are already supported by the compiler and can be handled > correctly, but functions that can be implemented on the LoongArch > architecture directly using the "bstrins" directi

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-16 Thread chenxiaolong
Thanks for the tip! Similar functions (e.g. __builtin_fabsf128 (_Float128 a) are already supported by the compiler and can be handled correctly, but functions that can be implemented on the LoongArch architecture directly using the "bstrins" directive (e.g. fabsq, copysignq, etc.) are better optimi

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-15 Thread Joseph Myers
On Tue, 15 Aug 2023, chenxiaolong wrote: > In the implementation process, the "q" suffix function is > Re-register and associate the "__float128" type with the > "long double" type so that the compiler can handle the > corresponding function correctly. The functions i

Re: [PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-15 Thread Xi Ruoyao via Gcc-patches
Please fix code style (this is the third time I say it and I'm really frustrated now). GCC is a project, it's not a student homework so style matters. And it's not so difficult to fix the style: for a new file you can use "clang-format --style GNU -i filename.c" to do the work automatically. On

[PATCH v3] LoongArch:Implement 128-bit floating point functions in gcc.

2023-08-15 Thread chenxiaolong
In the implementation process, the "q" suffix function is Re-register and associate the "__float128" type with the "long double" type so that the compiler can handle the corresponding function correctly. The functions implemented include __builtin_{huge_valq