Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-31 Thread Kamil Rytarowski
On 31.10.2017 19:45, Jakub Jelinek wrote: > On Tue, Oct 31, 2017 at 07:28:23PM +0100, Kamil Rytarowski wrote: >> I'm giving it a try. I took the asan part and skipped >> "%{!shared:libasan_preinit%O%s} ". If I understand this correctly, it >> attempts to use the ELF section with preinit property in

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-31 Thread Jakub Jelinek
On Tue, Oct 31, 2017 at 07:28:23PM +0100, Kamil Rytarowski wrote: > I'm giving it a try. I took the asan part and skipped > "%{!shared:libasan_preinit%O%s} ". If I understand this correctly, it > attempts to use the ELF section with preinit property in order to > bootstrap asan quickly. The preinit

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-31 Thread Kamil Rytarowski
On 31.10.2017 15:04, Jakub Jelinek wrote: > On Tue, Oct 31, 2017 at 02:53:26PM +0100, Kamil Rytarowski wrote: http://netbsd.org/~kamil/gcc/test_summary.log.8-20171022.txt >>> >>> That seems that asan pretty much doesn't work at all in GCC for netbsd. >>> A few FAILs might be acceptable, but so

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-31 Thread Jakub Jelinek
On Tue, Oct 31, 2017 at 02:53:26PM +0100, Kamil Rytarowski wrote: > >> http://netbsd.org/~kamil/gcc/test_summary.log.8-20171022.txt > > > > That seems that asan pretty much doesn't work at all in GCC for netbsd. > > A few FAILs might be acceptable, but so many FAILs certainly aren't. > > The tests

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-31 Thread Kamil Rytarowski
On 31.10.2017 14:22, Jakub Jelinek wrote: > On Mon, Oct 30, 2017 at 09:01:25PM +0100, Kamil Rytarowski wrote: >> On 30.10.2017 08:24, Jakub Jelinek wrote: >>> On Thu, Oct 26, 2017 at 09:50:43PM +0200, Kamil Rytarowski wrote: $ make check-asan $ make check-asan-dynamic $ make check-ub

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-31 Thread Jakub Jelinek
On Mon, Oct 30, 2017 at 09:01:25PM +0100, Kamil Rytarowski wrote: > On 30.10.2017 08:24, Jakub Jelinek wrote: > > On Thu, Oct 26, 2017 at 09:50:43PM +0200, Kamil Rytarowski wrote: > >> $ make check-asan > >> $ make check-asan-dynamic > >> $ make check-ubsan > > > > That is testing of the upstream

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-30 Thread Kamil Rytarowski
On 30.10.2017 08:24, Jakub Jelinek wrote: > On Thu, Oct 26, 2017 at 09:50:43PM +0200, Kamil Rytarowski wrote: >> $ make check-asan >> $ make check-asan-dynamic >> $ make check-ubsan > > That is testing of the upstream code, not of GCC and the libsanitizer > copy in GCC. What I'm more interested t

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-30 Thread Jakub Jelinek
On Thu, Oct 26, 2017 at 09:50:43PM +0200, Kamil Rytarowski wrote: > $ make check-asan > $ make check-asan-dynamic > $ make check-ubsan That is testing of the upstream code, not of GCC and the libsanitizer copy in GCC. What I'm more interested to hear is whether you've bootstrapped/regtested the g

[PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-26 Thread Kamil Rytarowski
Tested on: $ uname -rms NetBSD 8.99.4 amd64 The NetBSD support has been developed directly in the compiler-rt upstream source. Testing against the LLVM+Clang+compiler-rt (2017-10-25 snapshot from HEAD): $ make check-asan Failing Tests (2): AddressSanitizer-Unit :: ./Asan-x86_64-calls-Test/