Re: [PATCH v2 2/8] ifn: Add else-operand handling.

2024-10-29 Thread Robin Dapp
>> +/* Integer constants representing which else value is supported for masked >> load >> + functions. */ >> +#define MASK_LOAD_ELSE_ZERO -1 >> +#define MASK_LOAD_ELSE_M1 -2 >> +#define MASK_LOAD_ELSE_UNDEFINED -3 >> + >> +#define MASK_LOAD_GATHER_ELSE_IDX 6 > > Why this define? I initially wa

Re: [PATCH v2 2/8] ifn: Add else-operand handling.

2024-10-22 Thread Richard Sandiford
I agree with Richard's comments, but a couple more: Robin Dapp writes: > @@ -362,6 +363,23 @@ add_mask_and_len_args (expand_operand *ops, unsigned int > opno, gcall *stmt) > >create_input_operand (&ops[opno++], mask_rtx, > TYPE_MODE (TREE_TYPE (mask))); > + N

Re: [PATCH v2 2/8] ifn: Add else-operand handling.

2024-10-22 Thread Richard Biener
On Fri, 18 Oct 2024, Robin Dapp wrote: > This patch adds else-operand handling to the internal functions. > > gcc/ChangeLog: > > * internal-fn.cc (add_mask_and_len_args): Rename... > (add_mask_else_and_len_args): ...to this and add else handling. > (expand_partial_load_optab_fn

[PATCH v2 2/8] ifn: Add else-operand handling.

2024-10-18 Thread Robin Dapp
This patch adds else-operand handling to the internal functions. gcc/ChangeLog: * internal-fn.cc (add_mask_and_len_args): Rename... (add_mask_else_and_len_args): ...to this and add else handling. (expand_partial_load_optab_fn): Use adjusted function. (expand_partia