Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-22 Thread Andi Kleen
> > See the thread about the instrumentation pass which currently > > is implemented on GIMPLE. > > What are the issues for instrumenting as an RTL pass? It just needs to be completely rewritten and might be more complicated. And it might be more difficult to avoid redundant instrumentation with

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-22 Thread H.J. Lu
On Thu, Nov 22, 2018 at 5:24 AM Richard Biener wrote: > > On Wed, Nov 21, 2018 at 4:38 PM H.J. Lu wrote: > > > > On Wed, Nov 21, 2018 at 6:48 AM Richard Biener > > wrote: > > > > > > On Tue, Nov 20, 2018 at 7:36 PM Andi Kleen wrote: > > > > > > > > On Tue, Nov 20, 2018 at 11:53:15AM +0100, Rich

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-22 Thread Richard Biener
On Wed, Nov 21, 2018 at 4:38 PM H.J. Lu wrote: > > On Wed, Nov 21, 2018 at 6:48 AM Richard Biener > wrote: > > > > On Tue, Nov 20, 2018 at 7:36 PM Andi Kleen wrote: > > > > > > On Tue, Nov 20, 2018 at 11:53:15AM +0100, Richard Biener wrote: > > > > On Fri, Nov 16, 2018 at 8:07 AM Uros Bizjak wr

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-21 Thread H.J. Lu
On Wed, Nov 21, 2018 at 6:48 AM Richard Biener wrote: > > On Tue, Nov 20, 2018 at 7:36 PM Andi Kleen wrote: > > > > On Tue, Nov 20, 2018 at 11:53:15AM +0100, Richard Biener wrote: > > > On Fri, Nov 16, 2018 at 8:07 AM Uros Bizjak wrote: > > > > > > > > On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-21 Thread Richard Biener
On Tue, Nov 20, 2018 at 7:36 PM Andi Kleen wrote: > > On Tue, Nov 20, 2018 at 11:53:15AM +0100, Richard Biener wrote: > > On Fri, Nov 16, 2018 at 8:07 AM Uros Bizjak wrote: > > > > > > On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > > > > > > > From: Andi Kleen > > > > > > > > The earlier

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-20 Thread Andi Kleen
On Tue, Nov 20, 2018 at 11:53:15AM +0100, Richard Biener wrote: > On Fri, Nov 16, 2018 at 8:07 AM Uros Bizjak wrote: > > > > On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > > > > > From: Andi Kleen > > > > > > The earlier PTWRITE builtin definition was unnecessarily restrictive, > > > only

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-20 Thread Richard Biener
On Fri, Nov 16, 2018 at 8:07 AM Uros Bizjak wrote: > > On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > > > From: Andi Kleen > > > > The earlier PTWRITE builtin definition was unnecessarily restrictive, > > only allowing register input to PTWRITE. The instruction actually > > supports memor

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-15 Thread Uros Bizjak
On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > From: Andi Kleen > > The earlier PTWRITE builtin definition was unnecessarily restrictive, > only allowing register input to PTWRITE. The instruction actually > supports memory operands too, so allow that too. > > gcc/: > > 2018-11-15 Andi Kl

[PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-15 Thread Andi Kleen
From: Andi Kleen The earlier PTWRITE builtin definition was unnecessarily restrictive, only allowing register input to PTWRITE. The instruction actually supports memory operands too, so allow that too. gcc/: 2018-11-15 Andi Kleen * config/i386/i386.md: Allow memory operands to ptwri