Re: PING: [PATCH v2] x86: Fix -fsplit-stack feature detection via TARGET_CAN_SPLIT_STACK

2022-05-18 Thread Uros Bizjak via Gcc-patches
On Wed, May 18, 2022 at 9:34 AM Sören Tempel wrote: > > Hi, > > Uros Bizjak wrote: > > > > > gcc/ChangeLog: > > > > > > > > > > * config/i386/gnu-user-common.h (defined): Only define > > > > > TARGET_CAN_SPLIT_STACK for glibc targets. > > > > > * config/i386/gnu.h (defined): Ditto

Re: PING: [PATCH v2] x86: Fix -fsplit-stack feature detection via TARGET_CAN_SPLIT_STACK

2022-05-18 Thread Sören Tempel via Gcc-patches
Hi, Uros Bizjak wrote: > > > > gcc/ChangeLog: > > > > > > > > * config/i386/gnu-user-common.h (defined): Only define > > > > TARGET_CAN_SPLIT_STACK for glibc targets. > > > > * config/i386/gnu.h (defined): Ditto. > > This looks good to me, so OK. > > Thanks, > Uros. I am not de

Re: PING: [PATCH v2] x86: Fix -fsplit-stack feature detection via TARGET_CAN_SPLIT_STACK

2022-05-03 Thread Uros Bizjak via Gcc-patches
On Sun, May 1, 2022 at 4:20 PM Sören Tempel wrote: > > Pinging this again. This time with i386 port maintainers in CC. > > Summary: The macro guards for TARGET_CAN_SPLIT_STACK on i386 are not > aligned with the implementation of ix86_supports_split_stack. That is, > on systems using musl libc ix86

Re: PING: [PATCH v2] x86: Fix -fsplit-stack feature detection via TARGET_CAN_SPLIT_STACK

2022-05-01 Thread Sören Tempel via Gcc-patches
Pinging this again. This time with i386 port maintainers in CC. Summary: The macro guards for TARGET_CAN_SPLIT_STACK on i386 are not aligned with the implementation of ix86_supports_split_stack. That is, on systems using musl libc ix86_supports_split_stack errors-out (since -fsplit-stack is not su

PING: [PATCH v2] x86: Fix -fsplit-stack feature detection via TARGET_CAN_SPLIT_STACK

2022-03-14 Thread Sören Tempel via Gcc-patches
Ping. Summary: Currently, the macro guards for TARGET_CAN_SPLIT_STACK are not aligned with the implementation of ix86_supports_split_stack on x86. That is, on musl systems TARGET_CAN_SPLIT_STACK is defined even though -fsplit-stack is not supported (via ix86_supports_split_stack). This prevents gc

[PATCH v2] x86: Fix -fsplit-stack feature detection via TARGET_CAN_SPLIT_STACK

2022-02-21 Thread soeren--- via Gcc-patches
From: Sören Tempel Since commit c163647ffbc9a20c8feb6e079dbecccfe016c82e -fsplit-stack is only supported on glibc targets. However, this original commit required some fixups. As part of the fixup, the changes to the gnu-user-common.h and gnu.h were partially reverted in commit 60953a23d57b13a672f