Re: [PATCH v2] rtl-optimization: ppc backend generates unnecessary extension.

2023-03-30 Thread Segher Boessenkool
Hi! On Thu, Mar 30, 2023 at 04:28:51PM +0200, Bernhard Reutner-Fischer wrote: > On Thu, 30 Mar 2023 17:30:43 +0530 > Ajit Agarwal via Gcc-patches wrote: > > * ree.cc(is_feasible_elim_across_basic_blocks): > > We often use the lispy _p suffix for predicates. > Maybe eliminate_across_bbs_p wou

Re: [PATCH v2] rtl-optimization: ppc backend generates unnecessary extension.

2023-03-30 Thread Bernhard Reutner-Fischer via Gcc-patches
On Thu, 30 Mar 2023 17:30:43 +0530 Ajit Agarwal via Gcc-patches wrote: > Hello All: Just some nits. And this seems to be an incremental diff ontop of your v2. You might want check for coding-style errors by running: contrib/check_GNU_style.py /tmp/ree-v2bis.patch > > This patch added enhance

Re: [PATCH v2] rtl-optimization: ppc backend generates unnecessary extension.

2023-03-30 Thread Segher Boessenkool
Hi! On Tue, Mar 28, 2023 at 10:19:27PM +0530, Ajit Agarwal wrote: > This patch makes REE pass as a default pass in rs6000 target. And > add necessary subroutines to eliminate extensions across basic blocks. Please wait with this until stage 1? Some comments: > rtl-optimization: ppc backen

Re: [PATCH v2] rtl-optimization: ppc backend generates unnecessary extension.

2023-03-30 Thread Ajit Agarwal via Gcc-patches
Hello All: This patch added enhancement to extimination elimination for rs6000 target. Bootstrapped and regtested on powerpc64-linux-gnu. Thanks & Regards Ajit rtl-optimization: ppc backend generates unnecessary extension. Eliminate unnecessary redundant zero extension within bas

[PATCH v2] rtl-optimization: ppc backend generates unnecessary extension.

2023-03-28 Thread Ajit Agarwal via Gcc-patches
Hello All: This patch makes REE pass as a default pass in rs6000 target. And add necessary subroutines to eliminate extensions across basic blocks. Bootstrapped and regtested on powerpc64-linu-gnu. Thanks & Regards Ajit rtl-optimization: ppc backend generates unnecessary extens