Re: [PATCH v2] diagnostics: Fix compile error for MinGW <7.0

2024-10-08 Thread Torbjorn SVENSSON
On 2024-10-08 01:30, Jonathan Yong wrote: On 9/28/24 12:49, Torbjörn SVENSSON wrote: Ok for trunk? Changes since v1: - Updated the commit message to mention the actual build error. - Switch to checking the required define rather than the version number of MinGW. Patch looks OK to me. T

Re: [PATCH v2] diagnostics: Fix compile error for MinGW <7.0

2024-10-07 Thread Jonathan Yong
On 9/28/24 12:49, Torbjörn SVENSSON wrote: Ok for trunk? Changes since v1: - Updated the commit message to mention the actual build error. - Switch to checking the required define rather than the version number of MinGW. Patch looks OK to me. Thanks for the reminder.

[PING] [PATCH v2] diagnostics: Fix compile error for MinGW <7.0

2024-10-07 Thread Torbjorn SVENSSON
Gentle ping :) Kind regards, Torbjörn On 2024-09-28 14:49, Torbjörn SVENSSON wrote: Ok for trunk? Changes since v1: - Updated the commit message to mention the actual build error. - Switch to checking the required define rather than the version number of MinGW. -- The define ENABLE_VIRTUAL

[PATCH v2] diagnostics: Fix compile error for MinGW <7.0

2024-09-28 Thread Torbjörn SVENSSON
Ok for trunk? Changes since v1: - Updated the commit message to mention the actual build error. - Switch to checking the required define rather than the version number of MinGW. -- The define ENABLE_VIRTUAL_TERMINAL_PROCESSING was introduced in MinGW 7.0 Build failure when building with MinGW