Re: [PATCH v2] c++: Fix ICE with template codes in check_narrowing [PR91465]

2020-02-13 Thread Jason Merrill
On 2/11/20 5:06 PM, Marek Polacek wrote: On Sun, Feb 09, 2020 at 01:51:13PM +0100, Jason Merrill wrote: On 2/6/20 7:30 PM, Marek Polacek wrote: In ed4f2c001a883b2456fc607a33f1c59f9c4ee65d I changed the call to fold_non_dependent_expr in check_narrowing to maybe_constant_value. That was the wron

Re: [PATCH v2] c++: Fix ICE with template codes in check_narrowing [PR91465]

2020-02-11 Thread Marek Polacek
On Sun, Feb 09, 2020 at 01:51:13PM +0100, Jason Merrill wrote: > On 2/6/20 7:30 PM, Marek Polacek wrote: > > In ed4f2c001a883b2456fc607a33f1c59f9c4ee65d I changed the call to > > fold_non_dependent_expr in check_narrowing to maybe_constant_value. > > That was the wrong thing to do as these tests sh