Re: [PATCH v2] c++, coroutines: Tidy up awaiter variable checks.

On 8/22/24 4:38 AM, Iain Sandoe wrote: Hi Jason, + if (!glvalue_p (o) && !xvalue_p (o)) +o = build_target_expr_with_type (o, TREE_TYPE (o), tf_warning_or_error); Maybe get_target_expr instead? done. + o = cp_build_init_expr (loc, e_proxy, convert_from_reference (o)); Why con

[PATCH v2] c++, coroutines: Tidy up awaiter variable checks.

Hi Jason, >>+ if (!glvalue_p (o) && !xvalue_p (o)) >>+o = build_target_expr_with_type (o, TREE_TYPE (o), tf_warning_or_error); >Maybe get_target_expr instead? done. >>+ o = cp_build_init_expr (loc, e_proxy, convert_from_reference (o)); >Why convert_from_reference (o)? If o were a re