Re: [PATCH v2] AArch64: Cleanup memset expansion

2023-11-14 Thread Wilco Dijkstra
Hi Richard, > +/* Maximum bytes set for an inline memset expansion.  With -Os use 3 STP > +   and 1 MOVI/DUP (same size as a call).  */ > +#define MAX_SET_SIZE(speed) (speed ? 256 : 96) > So it looks like this assumes we have AdvSIMD.  What about > -mgeneral-regs-only? After my strictalign bugf

Re: [PATCH v2] AArch64: Cleanup memset expansion

2023-11-14 Thread Richard Earnshaw
On 14/11/2023 16:23, Wilco Dijkstra wrote: Hi, I checked codesize on SPECINT2017, and 96 had practically identical size. Using 128 would also be a reasonable Os value with a very slight size increase, and 384 looks good for O2 - however I didn't want to tune these values as this is a cleanup

Re: [PATCH v2] AArch64: Cleanup memset expansion

2023-11-14 Thread Wilco Dijkstra
Hi, >>> I checked codesize on SPECINT2017, and 96 had practically identical size. >>> Using 128 would also be a reasonable Os value with a very slight size >>> increase, >>> and 384 looks good for O2 - however I didn't want to tune these values >>> as this >>> is a cleanup patch. >>> >>> Cheers, >