Re: [PATCH v2] AArch64: Add LUTI ACLE for SVE2

2024-07-24 Thread Kyrylo Tkachov
Hi Vladimir, > On 24 Jul 2024, at 11:41, Vladimir Miloserdov > wrote: > > External email: Use caution opening links or attachments > > > Hi Kyrill, > > Thanks for your prompt review again! > >> It looks like __ARM_FEATURE_LUT should guard the Advanced SIMD intrinsics >> for LUTI at least.

RE: [PATCH v2] AArch64: Add LUTI ACLE for SVE2

2024-07-24 Thread Vladimir Miloserdov
Hi Kyrill, Thanks for your prompt review again! >It looks like __ARM_FEATURE_LUT should guard the Advanced SIMD intrinsics for >LUTI at least. >Therefore we should add this macro definition only once those are implemented >as well. So I’d remove this hunk. I'm working on adding those Advanced S

Re: [PATCH v2] AArch64: Add LUTI ACLE for SVE2

2024-07-23 Thread Kyrylo Tkachov
Hi Vladimir, Thanks for the update, this patch looks much better now. Some more comments inline. > On 23 Jul 2024, at 14:47, vladimir.miloser...@arm.com wrote: > > External email: Use caution opening links or attachments > > > Hi All, > > Changes since V1: add missing MD constraints, rename i

[PATCH v2] AArch64: Add LUTI ACLE for SVE2

2024-07-23 Thread vladimir.miloserdov
Hi All, Changes since V1: add missing MD constraints, rename intrinsics, remove SME2 flag for LUT feature. Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. This depends on "Extend aarch64_feature_flags to 128 bits" work which is soon to be submitted upstream as we ran out of 64-b