Re: [PATCH v2][ASAN] Implement dynamic allocas/VLAs sanitization.​

2017-06-30 Thread Maxim Ostapenko
Hi, On 29/06/17 15:35, Jakub Jelinek wrote: Hi! Sorry for the review delay. On Mon, Jun 26, 2017 at 03:49:23PM +0300, Maxim Ostapenko wrote: (handle_builtin_stackrestore): Likewise. The function is called with _ between stack and restore. * match.pd: Add new pattern. Unles

Re: [PATCH v2][ASAN] Implement dynamic allocas/VLAs sanitization.​

2017-06-29 Thread Jakub Jelinek
Hi! Sorry for the review delay. On Mon, Jun 26, 2017 at 03:49:23PM +0300, Maxim Ostapenko wrote: > (handle_builtin_stackrestore): Likewise. The function is called with _ between stack and restore. > * match.pd: Add new pattern. Unless the patch relies on this, I think it should be

[PATCH v2][ASAN] Implement dynamic allocas/VLAs sanitization.​

2017-06-26 Thread Maxim Ostapenko
Hi, I'm sorry for a long delay. Here an updated patch. Following Jakub's suggestion from previous review, I've added a get_nonzero_bits stuff into handle_builtin_alloca in order to avoid redundant redzone size calculations in case we know that alloca has alignment >= ASAN_RED_ZONE_SIZE. Thus,