Re: [PATCH v1 0/4] Refactor long function expand_const_vector

2025-04-23 Thread Robin Dapp
These patches LGTM from myside. But please wait for other folks to comment. The series LGTM as well. But please wait with merging until GCC 15.1 is released (as requested by the release maintainers). -- Regards Robin

Re: [PATCH v1 0/4] Refactor long function expand_const_vector

2025-04-22 Thread 钟居哲
These patches LGTM from myside. But please wait for other folks to comment. juzhe.zh...@rivai.ai From: pan2.li Date: 2025-04-23 09:28 To: gcc-patches CC: juzhe.zhong; kito.cheng; jeffreyalaw; rdapp.gcc; ken.chen; hongtao.liu; Pan Li Subject: [PATCH v1 0/4] Refactor long function

[PATCH v1 0/4] Refactor long function expand_const_vector

2025-04-22 Thread pan2 . li
From: Pan Li Per discussion from PR118931 thread, the expand_const_vector is quit long with more than 500 lines, which is unfriendly for debugging and maintaince. Thus, we extract some sub functions to make it clear and delicate the concrete const vector expanding into sub functions. Aka: expan