RE: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P

2024-04-12 Thread Li, Pan2
Message- From: Li, Pan2 Sent: Friday, April 12, 2024 6:58 PM To: Kito Cheng Cc: juzhe.zh...@rivai.ai; gcc-patches Subject: RE: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P Sure thing, the FP_RETURN only acts on ABI_xxx similar to below: #define FP_RETURN

RE: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P

2024-04-12 Thread Li, Pan2
ssage- From: Kito Cheng Sent: Friday, April 12, 2024 4:56 PM To: Li, Pan2 Cc: juzhe.zh...@rivai.ai; gcc-patches Subject: Re: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P Does FP reg also need gurared with TARGET_HARD_FLOAT? could you try to compile that case with

Re: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P

2024-04-12 Thread Kito Cheng
1 PM > To: Li, Pan2 ; gcc-patches > Cc: kito.cheng ; Li, Pan2 > Subject: Re: [PATCH v1] RISC-V: Bugfix ICE non-vector in > TARGET_FUNCTION_VALUE_REGNO_P > > > > LGTM。 > > > > > > juzhe.zh...@rivai.ai > > > > From:

RE: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P

2024-04-11 Thread Li, Pan2
Committed, thanks Juzhe. Pan From: juzhe.zh...@rivai.ai Sent: Friday, April 12, 2024 2:11 PM To: Li, Pan2 ; gcc-patches Cc: kito.cheng ; Li, Pan2 Subject: Re: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P LGTM。 juzhe.zh

Re: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P

2024-04-11 Thread juzhe.zh...@rivai.ai
LGTM。 juzhe.zh...@rivai.ai From: pan2.li Date: 2024-04-12 14:08 To: gcc-patches CC: juzhe.zhong; kito.cheng; Pan Li Subject: [PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P From: Pan Li This patch would like to fix one ICE when vector is not enabled in hook

[PATCH v1] RISC-V: Bugfix ICE non-vector in TARGET_FUNCTION_VALUE_REGNO_P

2024-04-11 Thread pan2 . li
From: Pan Li This patch would like to fix one ICE when vector is not enabled in hook TARGET_FUNCTION_VALUE_REGNO_P implementation. The vector regno is available if and only if the TARGET_VECTOR is true. The previous implement missed this condition and then result in ICE when rv64gc build option