Re: [PATCH libcpp]: S_ISREG non-zero value does not always fit in a bool

2011-06-02 Thread Tom Tromey
> "John" == John Tytgat writes: John> 2011-05-29 John Tytgat John> * files.c (read_file_guts): Add test on non-zero value of S_ISREG. It seems reasonable enough to me. I am checking it in. Out of curiosity, do you know of a platform where this is an issue? Tom

[PATCH libcpp]: S_ISREG non-zero value does not always fit in a bool

2011-05-29 Thread John Tytgat
In libcpp/files.c the value of S_ISREG() is assigned to a bool variable. AFAIK a non-zero value of S_ISREG does not necessary fit into a bool (unsigned char) so on some systems the file reading is a bit less efficient wrt its buffer size determination. Please commit after positive review (I don't