Re: [PATCH libcpp]: Avoid crash in interpret_float_suffix

2012-05-10 Thread Tristan Gingold
On May 8, 2012, at 5:39 PM, Tom Tromey wrote: >> "Tristan" == Tristan Gingold writes: > > Tristan> 2012-05-04 Tristan Gingold > Tristan> * expr.c (interpret_float_suffix): Add a guard. > > Ok. Thanks, now committed.

Re: [PATCH libcpp]: Avoid crash in interpret_float_suffix

2012-05-08 Thread Tom Tromey
> "Tristan" == Tristan Gingold writes: Tristan> 2012-05-04 Tristan Gingold Tristan>* expr.c (interpret_float_suffix): Add a guard. Ok. Tom

Re: [PATCH libcpp]: Avoid crash in interpret_float_suffix

2012-05-04 Thread Dodji Seketeli
Tristan Gingold a écrit: > the function libcpp/expr.c:interpret_float_suffix allows its argument > LEN to be 0, but in this case it tries to read before the buffer S. > It is not a real issue, except in case of overflow: on VMS with 64bit > pointers but 32bit size_t, the following code: s[len-1]

[PATCH libcpp]: Avoid crash in interpret_float_suffix

2012-05-04 Thread Tristan Gingold
Hi, the function libcpp/expr.c:interpret_float_suffix allows its argument LEN to be 0, but in this case it tries to read before the buffer S. It is not a real issue, except in case of overflow: on VMS with 64bit pointers but 32bit size_t, the following code: s[len-1] is evaluated as s[0xf