Re: [PATCH V2 3/3] OpenMP: Use enumerators for names of trait-sets and traits

2023-11-27 Thread Tobias Burnus
On 27.11.23 18:19, Tobias Burnus wrote: + { "unified_address", + (1 << OMP_TRAIT_SET_IMPLEMENTATION), + OMP_TRAIT_PROPERTY_NONE, true, + NULL + }, I don't understand this code. This looks as if "requires" and "unified_address" are on the same level but in my understanding they h

Re: [PATCH V2 3/3] OpenMP: Use enumerators for names of trait-sets and traits

2023-11-27 Thread Tobias Burnus
Hi Sandra, {BTW: 1/3 needs to be eventually rebased as it no longer applies cleanly; I have not checked 2/3 or 3/3 yet.] 1/3+2/3 look good to me, unless Jakub has some comments, I think they can go it. Regarding 3/3, some first comments. I still want to read it a bit more careful and play with

[PATCH V2 3/3] OpenMP: Use enumerators for names of trait-sets and traits

2023-11-22 Thread Sandra Loosemore
This patch introduces enumerators to represent trait-set names and trait names, which makes it easier to use tables to control other behavior and for switch statements to dispatch on the tags. The tags are stored in the same place in the TREE_LIST structure (OMP_TSS_ID or OMP_TS_ID) and are encode