Re: [PATCH RFC] c++: add -Wsfinae-incomplete

2025-06-16 Thread Patrick Palka
On Sat, 14 Jun 2025, Jason Merrill wrote: > On 6/13/25 1:36 PM, Patrick Palka wrote: > > On Fri, 13 Jun 2025, Jason Merrill wrote: > > > > > Tested x86_64-pc-linux-gnu, any comments? Bikeshedding? > > > > > > -- 8< -- > > > > > > We already error about a type definition causing a concept check

Re: [PATCH RFC] c++: add -Wsfinae-incomplete

2025-06-13 Thread Jason Merrill
On 6/13/25 1:36 PM, Patrick Palka wrote: On Fri, 13 Jun 2025, Jason Merrill wrote: Tested x86_64-pc-linux-gnu, any comments? Bikeshedding? -- 8< -- We already error about a type definition causing a concept check to change value, but it would be useful to diagnose this for other SFINAE conte

Re: [PATCH RFC] c++: add -Wsfinae-incomplete

2025-06-13 Thread Patrick Palka
On Fri, 13 Jun 2025, Jason Merrill wrote: > Tested x86_64-pc-linux-gnu, any comments? Bikeshedding? > > -- 8< -- > > We already error about a type definition causing a concept check to change > value, but it would be useful to diagnose this for other SFINAE contexts as > well; the memoization p

[PATCH RFC] c++: add -Wsfinae-incomplete

2025-06-13 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, any comments? Bikeshedding? -- 8< -- We already error about a type definition causing a concept check to change value, but it would be useful to diagnose this for other SFINAE contexts as well; the memoization problem also affects templates. So -Wsfinae-incomplete re