On Apr 22, 2011, Jason Merrill wrote:
> On 04/22/2011 02:13 AM, Mike Stump wrote:
>> http://gcc.gnu.org/ml/gcc/2005-04/msg00161.html
>>
>> has the details of why the code was put in.
> Right. At the time, we were sorting the goto queue based on pointer
> values, which caused the problem. We n
On Fri, Apr 22, 2011 at 12:59:21AM -0400, Jason Merrill wrote:
> On 04/21/2011 10:55 PM, Nathan Froyd wrote:
>> On Thu, Apr 21, 2011 at 10:49:05PM -0400, Jason Merrill wrote:
>>> Hunh. How does that work? They fill in CASE_LABEL later? Can that be
>>> changed?
>>
>> Yeah, tree-eh.c:lower_try_fin
On Apr 22, 2011, at 8:55 AM, Jason Merrill wrote:
> On 04/22/2011 02:13 AM, Mike Stump wrote:
>> http://gcc.gnu.org/ml/gcc/2005-04/msg00161.html
>>
>> has the details of why the code was put in.
>
> Right. At the time, we were sorting the goto queue based on pointer values,
> which caused the
On 04/22/2011 02:13 AM, Mike Stump wrote:
http://gcc.gnu.org/ml/gcc/2005-04/msg00161.html
has the details of why the code was put in.
Right. At the time, we were sorting the goto queue based on pointer
values, which caused the problem. We no longer do that, so we shouldn't
need this wor
On Fri, Apr 22, 2011 at 11:12:01AM +0200, Richard Guenther wrote:
> On Fri, Apr 22, 2011 at 8:13 AM, Mike Stump wrote:
> > Unsurprising... It will never fail during testsuite run, and won't
> > always fail during a bootstrap.
> >
> >> I can't think what the comment would be talking about with poi
On Fri, Apr 22, 2011 at 8:13 AM, Mike Stump wrote:
> On Apr 21, 2011, at 9:59 PM, Jason Merrill wrote:
>> On 04/21/2011 10:55 PM, Nathan Froyd wrote:
>>> On Thu, Apr 21, 2011 at 10:49:05PM -0400, Jason Merrill wrote:
Hunh. How does that work? They fill in CASE_LABEL later? Can that be
On Apr 21, 2011, at 9:59 PM, Jason Merrill wrote:
> On 04/21/2011 10:55 PM, Nathan Froyd wrote:
>> On Thu, Apr 21, 2011 at 10:49:05PM -0400, Jason Merrill wrote:
>>> Hunh. How does that work? They fill in CASE_LABEL later? Can that be
>>> changed?
>>
>> Yeah, tree-eh.c:lower_try_finally_switch.
On 04/21/2011 10:55 PM, Nathan Froyd wrote:
On Thu, Apr 21, 2011 at 10:49:05PM -0400, Jason Merrill wrote:
Hunh. How does that work? They fill in CASE_LABEL later? Can that be
changed?
Yeah, tree-eh.c:lower_try_finally_switch. I don't know how easy it is
to fix; it certainly looks non-triv
On Thu, Apr 21, 2011 at 10:49:05PM -0400, Jason Merrill wrote:
> On 04/21/2011 08:50 PM, Nathan Froyd wrote:
>> On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote:
>>> As jsm and richi said, using input_location like this is a regression.
>>> Can we use DECL_SOURCE_LOCATION (label_decl)
On 04/21/2011 08:50 PM, Nathan Froyd wrote:
On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote:
As jsm and richi said, using input_location like this is a regression.
Can we use DECL_SOURCE_LOCATION (label_decl) instead?
I went off and tried that; some callers provide a NULL label_d
On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote:
> On 03/24/2011 09:15 AM, Nathan Froyd wrote:
>> + tree t = make_node (CASE_LABEL_EXPR);
>> +
>> + TREE_TYPE (t) = void_type_node;
>> + SET_EXPR_LOCATION (t, input_location);
>
> As jsm and richi said, using input_location like this
On Thu, 14 Apr 2011, Nathan Froyd wrote:
> On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote:
> > On 03/24/2011 09:15 AM, Nathan Froyd wrote:
> >> + tree t = make_node (CASE_LABEL_EXPR);
> >> +
> >> + TREE_TYPE (t) = void_type_node;
> >> + SET_EXPR_LOCATION (t, input_location);
> >
On Thu, 14 Apr 2011, Nathan Froyd wrote:
> On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote:
> > On 03/24/2011 09:15 AM, Nathan Froyd wrote:
> >> + tree t = make_node (CASE_LABEL_EXPR);
> >> +
> >> + TREE_TYPE (t) = void_type_node;
> >> + SET_EXPR_LOCATION (t, input_location);
> >
On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote:
> On 03/24/2011 09:15 AM, Nathan Froyd wrote:
>> + tree t = make_node (CASE_LABEL_EXPR);
>> +
>> + TREE_TYPE (t) = void_type_node;
>> + SET_EXPR_LOCATION (t, input_location);
>
> As jsm and richi said, using input_location like this
On 03/24/2011 09:15 AM, Nathan Froyd wrote:
The C++-specific bits of these patches:
[PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00557.html
OK.
[PATCH 07/18] generalize build_case_label to the rest of the compiler
http://gcc
On Thu, Mar 24, 2011 at 06:15:18AM -0700, Nathan Froyd wrote:
> The C++-specific bits of these patches:
>
> [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses
> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00557.html
>
> [PATCH 07/18] generalize build_case_label to the rest of the comp
The C++-specific bits of these patches:
[PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00557.html
[PATCH 07/18] generalize build_case_label to the rest of the compiler
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00557.html
[PATCH 0
17 matches
Mail list logo
