On 1/21/20 5:19 AM, Iain Sandoe wrote:
Hi Nathan, Bin,
bin.cheng wrote:
Nathan, is this OK for trunk as-is?
thanks
Iain
ok, with one nit I noticed:
+act_des_fn (tree orig, tree fn_type, tree coro_frame_ptr, const char* name)
that final parameter should be 'const char *name' -- the '*'
Hi Nathan, Bin,
bin.cheng wrote:
> On Mon, Jan 20, 2020 at 10:59 PM Iain Sandoe wrote:
>> Hi Bin,
>>
>> bin.cheng wrote:
>>
>>> By standard, coroutine body should be encapsulated in try-catch block
>>> as following:
>>> try {
>>>// coroutine body
>>> } catch(...) {
>>>promise.unhan
On Mon, Jan 20, 2020 at 10:59 PM Iain Sandoe wrote:
>
> Hi Bin,
>
> bin.cheng wrote:
>
> > By standard, coroutine body should be encapsulated in try-catch block
> > as following:
> > try {
> > // coroutine body
> > } catch(...) {
> > promise.unhandled_exception();
> > }
> > Given above t
Hi Bin,
bin.cheng wrote:
> By standard, coroutine body should be encapsulated in try-catch block
> as following:
> try {
>// coroutine body
> } catch(...) {
>promise.unhandled_exception();
> }
> Given above try-catch block is implemented in the coroutine actor
> function called by cor
Hi,
By standard, coroutine body should be encapsulated in try-catch block
as following:
try {
// coroutine body
} catch(...) {
promise.unhandled_exception();
}
Given above try-catch block is implemented in the coroutine actor
function called by coroutine ramp function, so the promise