Re: [PATCH Coroutines]Access promise via actor function's frame pointer argument

2020-01-27 Thread Nathan Sidwell
On 1/21/20 5:19 AM, Iain Sandoe wrote: Hi Nathan, Bin, bin.cheng wrote: Nathan, is this OK for trunk as-is? thanks Iain ok, with one nit I noticed: +act_des_fn (tree orig, tree fn_type, tree coro_frame_ptr, const char* name) that final parameter should be 'const char *name' -- the '*'

Re: [PATCH Coroutines]Access promise via actor function's frame pointer argument

2020-01-21 Thread Iain Sandoe
Hi Nathan, Bin, bin.cheng wrote: > On Mon, Jan 20, 2020 at 10:59 PM Iain Sandoe wrote: >> Hi Bin, >> >> bin.cheng wrote: >> >>> By standard, coroutine body should be encapsulated in try-catch block >>> as following: >>> try { >>>// coroutine body >>> } catch(...) { >>>promise.unhan

Re: [PATCH Coroutines]Access promise via actor function's frame pointer argument

2020-01-20 Thread bin.cheng
On Mon, Jan 20, 2020 at 10:59 PM Iain Sandoe wrote: > > Hi Bin, > > bin.cheng wrote: > > > By standard, coroutine body should be encapsulated in try-catch block > > as following: > >  try { > >    // coroutine body > >  } catch(...) { > >    promise.unhandled_exception(); > >  } > > Given above t

Re: [PATCH Coroutines]Access promise via actor function's frame pointer argument

2020-01-20 Thread Iain Sandoe
Hi Bin, bin.cheng wrote: > By standard, coroutine body should be encapsulated in try-catch block > as following: > try { >// coroutine body > } catch(...) { >promise.unhandled_exception(); > } > Given above try-catch block is implemented in the coroutine actor > function called by cor

[PATCH Coroutines]Access promise via actor function's frame pointer argument

2020-01-20 Thread bin.cheng
Hi, By standard, coroutine body should be encapsulated in try-catch block as following: try { // coroutine body } catch(...) { promise.unhandled_exception(); } Given above try-catch block is implemented in the coroutine actor function called by coroutine ramp function, so the promise