Re: [PATCH 7/8] ipa: Verify that const jump functions have corresponding value range

2024-11-18 Thread Martin Jambor
Hi, On Thu, Nov 07 2024, Aldy Hernandez wrote: > Aldy Hernandez writes: > >> Martin Jambor writes: >> >>> Hi, >>> >>> Because the simplified way of extracting value ranges from functions >>> does not look at scalar constants (as one of the versions had been >>> doing before) but instead rely on

Re: [PATCH 7/8] ipa: Verify that const jump functions have corresponding value range

2024-11-06 Thread Aldy Hernandez
Aldy Hernandez writes: > Martin Jambor writes: > >> Hi, >> >> Because the simplified way of extracting value ranges from functions >> does not look at scalar constants (as one of the versions had been >> doing before) but instead rely on the value range within the jump >> function already captur

Re: [PATCH 7/8] ipa: Verify that const jump functions have corresponding value range

2024-11-06 Thread Aldy Hernandez
Martin Jambor writes: > Hi, > > Because the simplified way of extracting value ranges from functions > does not look at scalar constants (as one of the versions had been > doing before) but instead rely on the value range within the jump > function already capturing the constant, I have added a v

Re: [PATCH 7/8] ipa: Verify that const jump functions have corresponding value range

2024-11-05 Thread Jan Hubicka
> > > On Tue, Nov 05 2024, Jan Hubicka wrote: > >> 2024-11-04 Martin Jambor > >> > >>* ipa-cp.cc (ipa_check_const_jf_vr): New function. > >>(ipa_value_range_from_jfunc): Call it when checking and when > >>dealing with a constant jump function. > >>(propagate_vr_across_jump_fun

Re: [PATCH 7/8] ipa: Verify that const jump functions have corresponding value range

2024-11-05 Thread Jan Hubicka
> 2024-11-04 Martin Jambor > > * ipa-cp.cc (ipa_check_const_jf_vr): New function. > (ipa_value_range_from_jfunc): Call it when checking and when > dealing with a constant jump function. > (propagate_vr_across_jump_function): Likewise. OK > + /* TODO: Non-nullness is

Re: [PATCH 7/8] ipa: Verify that const jump functions have corresponding value range

2024-11-05 Thread Martin Jambor
On Tue, Nov 05 2024, Jan Hubicka wrote: >> 2024-11-04 Martin Jambor >> >> * ipa-cp.cc (ipa_check_const_jf_vr): New function. >> (ipa_value_range_from_jfunc): Call it when checking and when >> dealing with a constant jump function. >> (propagate_vr_across_jump_function): L

[PATCH 7/8] ipa: Verify that const jump functions have corresponding value range

2024-11-05 Thread Martin Jambor
Hi, Because the simplified way of extracting value ranges from functions does not look at scalar constants (as one of the versions had been doing before) but instead rely on the value range within the jump function already capturing the constant, I have added a verifier that it is indeed so. Afte