Re: [PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-27 Thread Jan Hubicka
> > Hi, > > > > when inlining (during the analysis phase) a call graph edge, we update > > all pass-through jump functions corresponding to edges going out of > > the newly inlined function to be relative to the function into which > > we are inlining or to expose the information originally capture

Re: [PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-27 Thread Martin Jambor
Hello, I believe all questions regarding the patch below have been answered and so I would like to ping it. Thanks, Martin On Tue, Nov 05 2024, Martin Jambor wrote: > Hi, > > when inlining (during the analysis phase) a call graph edge, we update > all pass-through jump functions corresponding

Re: [PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-15 Thread Martin Jambor
Hi, On Fri, Nov 15 2024, Jan Hubicka wrote: >> >> On 11/15/24 10:19, Jan Hubicka wrote: >> > > I have seen this happen when the result of the intersection is an empty >> > > set (one of the few comments in value-range.h actually describes an >> > > undefined range as an "empty range"). I have on

Re: [PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-15 Thread Jan Hubicka
> > On 11/15/24 10:19, Jan Hubicka wrote: > > > I have seen this happen when the result of the intersection is an empty > > > set (one of the few comments in value-range.h actually describes an > > > undefined range as an "empty range"). I have only seen this happen when > > > the edge has been r

Re: [PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-15 Thread Andrew MacLeod
On 11/15/24 10:19, Jan Hubicka wrote: I have seen this happen when the result of the intersection is an empty set (one of the few comments in value-range.h actually describes an undefined range as an "empty range"). I have only seen this happen when the edge has been redirected to builtin_unre

Re: [PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-15 Thread Jan Hubicka
> > I have seen this happen when the result of the intersection is an empty > set (one of the few comments in value-range.h actually describes an > undefined range as an "empty range"). I have only seen this happen when > the edge has been redirected to builtin_unreachable because, the has > been

Re: [PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-15 Thread Martin Jambor
Hi, On Tue, Nov 05 2024, Jan Hubicka wrote: >> Hi, >> >> when inlining (during the analysis phase) a call graph edge, we update >> all pass-through jump functions corresponding to edges going out of >> the newly inlined function to be relative to the function into which >> we are inlining or to e

Re: [PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-05 Thread Jan Hubicka
> Hi, > > when inlining (during the analysis phase) a call graph edge, we update > all pass-through jump functions corresponding to edges going out of > the newly inlined function to be relative to the function into which > we are inlining or to expose the information originally captured for > the

[PATCH 5/8] ipa: Update value range jump functions during inlining

2024-11-05 Thread Martin Jambor
Hi, when inlining (during the analysis phase) a call graph edge, we update all pass-through jump functions corresponding to edges going out of the newly inlined function to be relative to the function into which we are inlining or to expose the information originally captured for the edge that is