Re: [PATCH 5/6] diagnostics: Support generated data in additional contexts

2022-11-04 Thread Lewis Hyatt via Gcc-patches
On Fri, Nov 04, 2022 at 12:42:29PM -0400, David Malcolm wrote: > On Fri, 2022-11-04 at 09:44 -0400, Lewis Hyatt via Gcc-patches wrote: > > Add awareness that diagnostic locations may be in generated buffers > > rather > > than an actual file to other places in the diagnostics code that may > > care

Re: [PATCH 5/6] diagnostics: Support generated data in additional contexts

2022-11-04 Thread David Malcolm via Gcc-patches
On Fri, 2022-11-04 at 09:44 -0400, Lewis Hyatt via Gcc-patches wrote: > Add awareness that diagnostic locations may be in generated buffers > rather > than an actual file to other places in the diagnostics code that may > care, > most notably SARIF output (which needs to obtain its own snapshots of

[PATCH 5/6] diagnostics: Support generated data in additional contexts

2022-11-04 Thread Lewis Hyatt via Gcc-patches
Add awareness that diagnostic locations may be in generated buffers rather than an actual file to other places in the diagnostics code that may care, most notably SARIF output (which needs to obtain its own snapshots of the code involved). For edit context output, which outputs fixit hints as diffs