Re: [PATCH 4/4] c++: enable modules by default in c++20

2024-10-21 Thread Jason Merrill
On 10/15/24 10:57 AM, Jakub Jelinek wrote: On Fri, Oct 11, 2024 at 10:41:36PM -0400, Jason Merrill wrote: The intent is that C++20 module header units obsolete PCH; they serve the same function and are more flexible (you can import multiple header units). Though, simple use of -std=c++20 or -s

Re: [PATCH 4/4] c++: enable modules by default in c++20

2024-10-15 Thread Jakub Jelinek
On Fri, Oct 11, 2024 at 10:41:36PM -0400, Jason Merrill wrote: > The intent is that C++20 module header units obsolete PCH; they serve the > same function and are more flexible (you can import multiple header units). Though, simple use of -std=c++20 or -std=c++23 doesn't imply one is using modules

Re: [PATCH 4/4] c++: enable modules by default in c++20

2024-10-11 Thread Jason Merrill
On 10/11/24 8:19 AM, Jakub Jelinek wrote: On Wed, Oct 09, 2024 at 07:06:26PM -0400, Patrick Palka wrote: On Wed, 9 Oct 2024, Jason Merrill wrote: Tested x86_64-pc-linux-gnu, will apply to trunk with the rest of the patch series. -- 8< -- At this point there doesn't seem to be much reason not

Re: [PATCH 4/4] c++: enable modules by default in c++20

2024-10-11 Thread Jakub Jelinek
On Wed, Oct 09, 2024 at 07:06:26PM -0400, Patrick Palka wrote: > On Wed, 9 Oct 2024, Jason Merrill wrote: > > > Tested x86_64-pc-linux-gnu, will apply to trunk with the rest of the patch > > series. > > > > -- 8< -- > > > > At this point there doesn't seem to be much reason not to have modules >

Re: [PATCH 4/4] c++: enable modules by default in c++20

2024-10-10 Thread Jason Merrill
On 10/9/24 7:06 PM, Patrick Palka wrote: On Wed, 9 Oct 2024, Jason Merrill wrote: Tested x86_64-pc-linux-gnu, will apply to trunk with the rest of the patch series. -- 8< -- At this point there doesn't seem to be much reason not to have modules support enabled by default in C++20, and it's go

Re: [PATCH 4/4] c++: enable modules by default in c++20

2024-10-09 Thread Patrick Palka
On Wed, 9 Oct 2024, Jason Merrill wrote: > Tested x86_64-pc-linux-gnu, will apply to trunk with the rest of the patch > series. > > -- 8< -- > > At this point there doesn't seem to be much reason not to have modules > support enabled by default in C++20, and it's good get more test coverage to >

[PATCH 4/4] c++: enable modules by default in c++20

2024-10-09 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, will apply to trunk with the rest of the patch series. -- 8< -- At this point there doesn't seem to be much reason not to have modules support enabled by default in C++20, and it's good get more test coverage to find corner case bugs like some I fixed recently. It als