Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

Hi, On Tue, Dec 03 2024, Richard Biener wrote: > On Tue, Dec 3, 2024 at 12:09 PM Martin Jambor wrote: >> On Fri, Nov 15 2024, Richard Biener wrote: >> > On Fri, Nov 15, 2024 at 1:45 PM Jan Hubicka wrote: >> >> > >> >> > The patch only ever skips just one conversion, never a chain of them and >>

Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

On Tue, Dec 3, 2024 at 12:09 PM Martin Jambor wrote: > > Hi, > > sorry for re-posting this but my mail client broke threading when > saving the email as Draft somehow and I really hope to still get this > testcase working for GCC 15: > > On Fri, Nov 15 2024, Richard Biener wrote: > > On Fri, Nov 1

Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

Hi, sorry for re-posting this but my mail client broke threading when saving the email as Draft somehow and I really hope to still get this testcase working for GCC 15: On Fri, Nov 15 2024, Richard Biener wrote: > On Fri, Nov 15, 2024 at 1:45 PM Jan Hubicka wrote: >> > >> > The patch only ever s

Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

Hi, On Fri, Nov 15 2024, Richard Biener wrote: > On Fri, Nov 15, 2024 at 1:45 PM Jan Hubicka wrote: >> >> > >> > The patch only ever skips just one conversion, never a chain of them and >> > deliberately so, for the reasons shown in the example. >> > >> > However, I have just realized that combin

Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

On Fri, Nov 15, 2024 at 1:45 PM Jan Hubicka wrote: > > > > > The patch only ever skips just one conversion, never a chain of them and > > deliberately so, for the reasons shown in the example. > > > > However, I have just realized that combining pass_through jump functions > > during inlining may

Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

> > The patch only ever skips just one conversion, never a chain of them and > deliberately so, for the reasons shown in the example. > > However, I have just realized that combining pass_through jump functions > during inlining may unfortunately have exactly the same effect, so we > indeed need

Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

Hi, On Tue, Nov 05 2024, Jan Hubicka wrote: >> gcc/ChangeLog: >> >> 2024-11-01 Martin Jambor >> >> * ipa-prop.cc (skip_a_conversion_op): New function. >> (ipa_compute_jump_functions_for_edge): Use it. >> >> gcc/testsuite/ChangeLog: >> >> 2024-11-01 Martin Jambor >> >> * g

Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

> gcc/ChangeLog: > > 2024-11-01 Martin Jambor > > * ipa-prop.cc (skip_a_conversion_op): New function. > (ipa_compute_jump_functions_for_edge): Use it. > > gcc/testsuite/ChangeLog: > > 2024-11-01 Martin Jambor > > * gcc.dg/ipa/vrp9.c: New test. > --- > gcc/ipa-prop.cc

Re: [PATCH 3/8] ipa: Skip type conversions in jump function constructions

Martin Jambor writes: > +/* If T is an SSA_NAME that is a result of a simple type conversion > statement, I think "the result" sounds better than "a result", assuming there is just one result. > + return the operand of that conversion, otherwise treturn T. */ s/treturn/return/ Aldy

[PATCH 3/8] ipa: Skip type conversions in jump function constructions

Hi, originally, we did not stream any formal parameter types into WPA and were generally very conservative when it came to type mismatches in IPA-CP. Over the time, mismatches that happen in code and blew up in WPA made us be much more resilient and also stream the types of the parameters which w