Re: [PATCH 3/4 GCC11] IVOPTs Consider cost_step on different forms during unrolling

2020-01-20 Thread Segher Boessenkool
Hi! On Mon, Jan 20, 2020 at 01:47:56PM +, Wilco Dijkstra wrote: > Would it not make more sense to use the TARGET_ADDRESS_COST hook > to return different costs for immediate offset and register offset addressing, > and ensure IVOpts correctly takes this into account? > > On AArch64 we've defin

Re: [PATCH 3/4 GCC11] IVOPTs Consider cost_step on different forms during unrolling

2020-01-20 Thread Wilco Dijkstra
Hi Kewen, Would it not make more sense to use the TARGET_ADDRESS_COST hook to return different costs for immediate offset and register offset addressing, and ensure IVOpts correctly takes this into account? On AArch64 we've defined different costs for immediate offset, register offset, register o

[PATCH 3/4 GCC11] IVOPTs Consider cost_step on different forms during unrolling

2020-01-16 Thread Kewen.Lin
gcc/ChangeLog 2020-01-16 Kewen Lin * tree-ssa-loop-ivopts.c (struct iv_group): New field dform_p. (struct iv_cand): New field dform_p. (struct ivopts_data): New field mark_dform_p. (record_group): Initialize dform_p. (mark_dform_groups): New function.