Re: [PATCH 3/4] split-stack for powerpc64

2015-05-29 Thread David Edelsohn
On Fri, May 29, 2015 at 10:47 AM, Alan Modra wrote: > Two fixes for -fsplit-stack on powerpc64. I goofed on the block > scanned for uses of r12. ENTRY_BLOCK_PTR_FOR_FN is the fake one. The > next block is the first one having insns. > > The second change emits an error if people use a global re

Re: [PATCH 3/4] split-stack for powerpc64

2015-05-29 Thread Alan Modra
Two fixes for -fsplit-stack on powerpc64. I goofed on the block scanned for uses of r12. ENTRY_BLOCK_PTR_FOR_FN is the fake one. The next block is the first one having insns. The second change emits an error if people use a global register variable r29 with -fsplit-stack. For example: register

Re: [PATCH 3/4] split-stack for powerpc64

2015-05-20 Thread Alan Modra
Older assemblers don't understand .abiversion, so I'm committing the following as obvious to fix a problem Michael Meissner found when building gcc for powerpc64-linux. PR libgcc/66225 * config/rs6000/morestack.S: Remove ".abiversion 1". Index: libgcc/config/rs6000/morestack.S ===

Re: [PATCH 3/4] split-stack for powerpc64

2015-05-20 Thread Lynn A. Boger
Anytime go code built with gccgo is linked against libraries built with gcc (without split stack) there could be mixing of split stack and non split stack code. I think that will be a common case. My understanding is that if you don't use the gold linker in these cases, it is possible that the a

Re: [PATCH 3/4] split-stack for powerpc64

2015-05-20 Thread David Edelsohn
On Wed, May 20, 2015 at 8:13 AM, Lynn A. Boger wrote: > > > On 05/19/2015 07:52 PM, Alan Modra wrote: >> >> On Tue, May 19, 2015 at 07:40:15AM -0500, Lynn A. Boger wrote: >>> >>> Questions on the use of the options for split stack: >>> >>> - The way this is implemented, split stack is generated if

Re: [PATCH 3/4] split-stack for powerpc64

2015-05-20 Thread Lynn A. Boger
On 05/19/2015 07:52 PM, Alan Modra wrote: On Tue, May 19, 2015 at 07:40:15AM -0500, Lynn A. Boger wrote: Questions on the use of the options for split stack: - The way this is implemented, split stack is generated if the target platform supports split stack, on ppc64/ppc64le as well as on x86

Re: [PATCH 3/4] split-stack for powerpc64

2015-05-19 Thread Alan Modra
On Tue, May 19, 2015 at 07:40:15AM -0500, Lynn A. Boger wrote: > Questions on the use of the options for split stack: > > - The way this is implemented, split stack is generated if the > target platform supports split stack, on ppc64/ppc64le as well > as on x86, and the use of -fno-split-stack doe

Re: [PATCH 3/4] split-stack for powerpc64

2015-05-17 Thread Alan Modra
On Mon, May 18, 2015 at 12:24:51PM +0930, Alan Modra wrote: > +error ("%<-fsplit-stack%> currently only supported on PowerPC64 > GNU/Linux with glibc-2.18 or later"); I forgot to comment on this. 2.19 is actually when __private_ss appeared in the ppc tcbhead_t, but I misread the commit date