Re: [PATCH 3/4] Factor out duplicate code in gimplify_scan_omp_clauses

2019-11-05 Thread Julian Brown
Hi Thomas! Here's a new version of the patch, with your comments below hopefully addressed. In particular the check_base_and_compare_lt function with the "weird" API has been replaced by a new, simpler extract_base_bit_offset function. Going back and re-examining the code, I think it makes more se

Re: [PATCH 3/4] Factor out duplicate code in gimplify_scan_omp_clauses

2019-10-16 Thread Thomas Schwinge
Hi Julian! On 2019-10-06T15:32:36-0700, Julian Brown wrote: > This patch factors out some code in gimplify_scan_omp_clauses into two > new outlined functions. Yay for such simplification, and yay for documenting what's going on! > Previously approved here: > > https://gcc.gnu.org/ml/gcc-patch

[PATCH 3/4] Factor out duplicate code in gimplify_scan_omp_clauses

2019-10-06 Thread Julian Brown
This patch factors out some code in gimplify_scan_omp_clauses into two new outlined functions. Previously approved here: https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01309.html FAOD, OK for trunk? Thanks, Julian ChangeLog gcc/ * gimplify.c (insert_struct_comp_map, check_bas