Re: [PATCH 3/4] Dump histograms only if present.

2019-06-06 Thread Jan Hubicka
> On 6/6/19 2:16 PM, Jan Hubicka wrote: > > What is the point of having histogram value when there are no counters? > > Because we first create histograms in branch_prob -> > gimple_find_values_to_profile and > later we read profile from file. At that point we know which are empty, but > we don'

Re: [PATCH 3/4] Dump histograms only if present.

2019-06-06 Thread Martin Liška
On 6/6/19 2:16 PM, Jan Hubicka wrote: > What is the point of having histogram value when there are no counters? Because we first create histograms in branch_prob -> gimple_find_values_to_profile and later we read profile from file. At that point we know which are empty, but we don't remove them.

Re: [PATCH 3/4] Dump histograms only if present.

2019-06-06 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2019-06-04 Martin Liska > > * value-prof.c (dump_histogram_value): Print histogram values > only if present. What is the point of having histogram value when there are no counters? Honza > --- > gcc/value-prof.c | 72 +++---

[PATCH 3/4] Dump histograms only if present.

2019-06-04 Thread marxin
gcc/ChangeLog: 2019-06-04 Martin Liska * value-prof.c (dump_histogram_value): Print histogram values only if present. --- gcc/value-prof.c | 72 +++- 1 file changed, 28 insertions(+), 44 deletions(-) diff --git a/gcc/value-prof.c b