Re: [PATCH 25/31] VAX: Fix predicates for widening multiply and multiply-add insns

2020-11-30 Thread Jeff Law via Gcc-patches
On 11/30/20 9:02 AM, Maciej W. Rozycki wrote: > On Fri, 20 Nov 2020, Jeff Law wrote: > >> ps.  Yes, I skipped the insv/extv changes.  They're usually a rats nest >> of special cases.  We'll come back to them. > I've thought of actually reducing the number of patterns to the minimum > possible

Re: [PATCH 25/31] VAX: Fix predicates for widening multiply and multiply-add insns

2020-11-30 Thread Maciej W. Rozycki
On Fri, 20 Nov 2020, Jeff Law wrote: > ps.  Yes, I skipped the insv/extv changes.  They're usually a rats nest > of special cases.  We'll come back to them. I've thought of actually reducing the number of patterns to the minimum possible by folding the existing ones together, and then getting t

Re: [PATCH 25/31] VAX: Fix predicates for widening multiply and multiply-add insns

2020-11-20 Thread Jeff Law via Gcc-patches
On 11/19/20 8:36 PM, Maciej W. Rozycki wrote: > It makes no sense for insn operand predicates, as long as they accept a > register operand, to be more restrictive than the set of the associated > constraints, because expand will choose the insn based on the relevant > operand being a pseudo regi

[PATCH 25/31] VAX: Fix predicates for widening multiply and multiply-add insns

2020-11-19 Thread Maciej W. Rozycki
It makes no sense for insn operand predicates, as long as they accept a register operand, to be more restrictive than the set of the associated constraints, because expand will choose the insn based on the relevant operand being a pseudo register then and reload will keep it happily as an immediate