Re: [PATCH 2/6] libstdc++: pstl: port away from is_trivial

2024-12-09 Thread Giuseppe D'Angelo
On 09/12/2024 14:13, Jonathan Wakely wrote: Could I ask you to open an issue about std::is_trivial upstream: https://github.com/oneapi-src/oneDPL/issues If/when they fix it, we can consider aligning with their direction. And that might resolve the question of which aspects of triviality are real

Re: [PATCH 2/6] libstdc++: pstl: port away from is_trivial

2024-12-09 Thread Jonathan Wakely
On 09/12/24 13:13 +, Jonathan Wakely wrote: On 09/12/24 13:08 +0100, Giuseppe D'Angelo wrote: For PSTL, I've just chosen to port from is_trivial to the direct equivalent, as I'm really unsure about the meaning of the code. Yeah, I'm not sure either. I note that the code uses std::conjunct

Re: [PATCH 2/6] libstdc++: pstl: port away from is_trivial

2024-12-09 Thread Jonathan Wakely
re. -- Giuseppe D'Angelo From a24a9495976a08f19df32dddf9b0e29661aca696 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Mon, 9 Dec 2024 02:06:25 +0100 Subject: [PATCH 2/6] libstdc++: pstl: port away from is_trivial In preparation for the deprecation of is_trivial (P3247R2). Unfortunately I

[PATCH 2/6] libstdc++: pstl: port away from is_trivial

2024-12-09 Thread Giuseppe D'Angelo
:06:25 +0100 Subject: [PATCH 2/6] libstdc++: pstl: port away from is_trivial In preparation for the deprecation of is_trivial (P3247R2). Unfortunately I am unable to fully understand what aspect of triviality seems to matter for these algorithms, so I just ported is_trivial to its direct equivalent