Re: [PATCH 2/4 v2] libcpp: Replace macro usage with C++ constructs)

2015-05-10 Thread Jan Hubicka
> On 05/05/2015 12:21 PM, David Malcolm wrote: > >On Mon, 2015-05-04 at 13:15 -0600, Jeff Law wrote: > >On 05/01/2015 06:56 PM, David Malcolm wrote: > >>> > >>>[I didn't mark the inline functions as "static"; should they be?] > Just a follow-up on this. I got burned by the ODR issues around > impl

Re: [PATCH 2/4 v2] libcpp: Replace macro usage with C++ constructs)

2015-05-08 Thread Jeff Law
On 05/05/2015 12:21 PM, David Malcolm wrote: On Mon, 2015-05-04 at 13:15 -0600, Jeff Law wrote: On 05/01/2015 06:56 PM, David Malcolm wrote: [I didn't mark the inline functions as "static"; should they be?] Just a follow-up on this. I got burned by the ODR issues around implicit extern inline

[PATCH 2/4 v2] libcpp: Replace macro usage with C++ constructs)

2015-05-05 Thread David Malcolm
On Mon, 2015-05-04 at 13:15 -0600, Jeff Law wrote: On 05/01/2015 06:56 PM, David Malcolm wrote: > > libcpp makes extensive use of the C preprocessor. Whilst this has a > > pleasingly self-referential quality, I find the code hard-to-read; > > implementing source location support in my JIT branch w