Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-11-23 Thread Charles Baylis
On 23 November 2017 at 10:01, Kyrill Tkachov wrote: > > Thanks, these are ok for trunk. > They were originally posted way before stage 3 and this is just a rework, > so it's acceptable at this stage as far as I'm concerned. Thanks. Committed to trunk as r255111.

Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-11-23 Thread Kyrill Tkachov
Hi Charles, On 20/11/17 21:09, Charles Baylis wrote: On 15 September 2017 at 18:01, Kyrill Tkachov wrote: > > On 15/09/17 16:38, Charles Baylis wrote: >> >> On 13 September 2017 at 10:02, Kyrill Tkachov >> wrote: >>> >>> Hi Charles, >>> >>> On 12/09/17 09:34, charles.bay...@linaro.org wrote:

Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-11-21 Thread Charles Baylis
On 20 November 2017 at 21:09, Charles Baylis wrote: > I have modified this patch accordingly. Patch 1 is no longer needed. > > Passes "make check" (with patch 3) on arm-linux-gnueabihf with no > regressions. Bootstrap is in progress. Bootstrap built successfully using qemu host. > Can I still g

Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-11-20 Thread Charles Baylis
On 15 September 2017 at 18:01, Kyrill Tkachov wrote: > > On 15/09/17 16:38, Charles Baylis wrote: >> >> On 13 September 2017 at 10:02, Kyrill Tkachov >> wrote: >>> >>> Hi Charles, >>> >>> On 12/09/17 09:34, charles.bay...@linaro.org wrote: From: Charles Baylis This patch mo

Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-09-15 Thread Kyrill Tkachov
On 15/09/17 16:38, Charles Baylis wrote: On 13 September 2017 at 10:02, Kyrill Tkachov wrote: Hi Charles, On 12/09/17 09:34, charles.bay...@linaro.org wrote: From: Charles Baylis This patch moves the calculation of costs for MEM into a separate function, and reforms the calculation into t

Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-09-15 Thread Charles Baylis
fix this. >> + *cost += CEIL (GET_MODE_SIZE (mode), bus_width_bytes); >> + *cost += extra_cost->ldst.load; >> +} >> + else >> +{ >> + *cost += COSTS_N_INSNS (1); >> +} > > Given my first comment above this else would be d

Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-09-13 Thread Kyrill Tkachov
Hi Charles, On 12/09/17 09:34, charles.bay...@linaro.org wrote: From: Charles Baylis This patch moves the calculation of costs for MEM into a separate function, and reforms the calculation into two parts. Firstly any additional cost of the addressing mode is calculated, and then the cost of th

[PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-09-12 Thread charles . baylis
From: Charles Baylis This patch moves the calculation of costs for MEM into a separate function, and reforms the calculation into two parts. Firstly any additional cost of the addressing mode is calculated, and then the cost of the memory access itself is added. In this patch, the calculation of