Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-14 Thread Trevor Saunders
On Thu, Aug 13, 2015 at 07:56:47PM +0300, Mikhail Maltsev wrote: > On 08/12/2015 11:36 PM, Trevor Saunders wrote: > > In many places gcc puts classes in the anon namespace so the compiler can > > tell > > they do not get inheritted from to enable better devirtualization. > C++ does not allow class

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-13 Thread Richard Sandiford
Trevor Saunders writes: > On Wed, Aug 12, 2015 at 01:03:36PM -0600, Jeff Law wrote: >> On 08/12/2015 12:57 PM, Richard Sandiford wrote: >> >Jeff Law writes: >> >>On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: >> >>>From: Trevor Saunders >> >>> >> >>>Hi, >> >>> >> >>>In many places gcc

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-13 Thread Mikhail Maltsev
On 08/12/2015 11:36 PM, Trevor Saunders wrote: > In many places gcc puts classes in the anon namespace so the compiler can tell > they do not get inheritted from to enable better devirtualization. C++ does not allow class members to have static linkage, so there is no way to tell the compiler that

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-13 Thread David Edelsohn
On Wed, Aug 12, 2015 at 4:30 PM, Trevor Saunders wrote: > On Wed, Aug 12, 2015 at 03:31:35PM -0400, David Edelsohn wrote: >> This patch has caused a bootstrap failure on AIX. > > reverted, though my bet is this is some sort of generic devirt bug on > aix. bootstrap with GCC 5 does not help. - Da

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-13 Thread David Edelsohn
On Wed, Aug 12, 2015 at 4:30 PM, Trevor Saunders wrote: > On Wed, Aug 12, 2015 at 03:31:35PM -0400, David Edelsohn wrote: >> This patch has caused a bootstrap failure on AIX. > > reverted, though my bet is this is some sort of generic devirt bug on > aix. There have been a lot of issues with GCC'

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread David Malcolm
On Thu, 2015-08-13 at 01:58 +0200, Markus Trippelsdorf wrote: > On 2015.08.12 at 13:03 -0600, Jeff Law wrote: > > On 08/12/2015 12:57 PM, Richard Sandiford wrote: > > > Jeff Law writes: > > >> On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: > > >>> From: Trevor Saunders > > >>> > > >>> H

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread Markus Trippelsdorf
On 2015.08.12 at 13:03 -0600, Jeff Law wrote: > On 08/12/2015 12:57 PM, Richard Sandiford wrote: > > Jeff Law writes: > >> On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: > >>> From: Trevor Saunders > >>> > >>> Hi, > >>> > >>> In many places gcc puts classes in the anon namespace so the

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread Trevor Saunders
On Wed, Aug 12, 2015 at 01:03:36PM -0600, Jeff Law wrote: > On 08/12/2015 12:57 PM, Richard Sandiford wrote: > >Jeff Law writes: > >>On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: > >>>From: Trevor Saunders > >>> > >>>Hi, > >>> > >>>In many places gcc puts classes in the anon namespace

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread Trevor Saunders
On Wed, Aug 12, 2015 at 03:31:35PM -0400, David Edelsohn wrote: > This patch has caused a bootstrap failure on AIX. reverted, though my bet is this is some sort of generic devirt bug on aix. Trev > > - David

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread David Edelsohn
This patch has caused a bootstrap failure on AIX. - David

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread Jeff Law
On 08/12/2015 12:57 PM, Richard Sandiford wrote: Jeff Law writes: On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders Hi, In many places gcc puts classes in the anon namespace so the compiler can tell they do not get inheritted from to enable better devirtualizati

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread Richard Sandiford
Jeff Law writes: > On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: >> From: Trevor Saunders >> >> Hi, >> >> In many places gcc puts classes in the anon namespace so the compiler can >> tell >> they do not get inheritted from to enable better devirtualization. However >> debugging code

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-11 Thread Jeff Law
On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders Hi, In many places gcc puts classes in the anon namespace so the compiler can tell they do not get inheritted from to enable better devirtualization. However debugging code in the anon namespace can be a pain, and

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-10 Thread Trevor Saunders
On Mon, Aug 10, 2015 at 03:56:02PM +0200, Markus Trippelsdorf wrote: > On 2015.08.10 at 08:05 -0400, tbsaunde+...@tbsaunde.org wrote: > > > > In many places gcc puts classes in the anon namespace so the compiler can > > tell > > they do not get inheritted from to enable better devirtualization.

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-10 Thread Markus Trippelsdorf
On 2015.08.10 at 08:05 -0400, tbsaunde+...@tbsaunde.org wrote: > > In many places gcc puts classes in the anon namespace so the compiler can tell > they do not get inheritted from to enable better devirtualization. However > debugging code in the anon namespace can be a pain, and the same thing c

[PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-10 Thread tbsaunde+gcc
From: Trevor Saunders Hi, In many places gcc puts classes in the anon namespace so the compiler can tell they do not get inheritted from to enable better devirtualization. However debugging code in the anon namespace can be a pain, and the same thing can be accomplished more directly by marking