Re: [v3 of PATCH 13/14] c-format.c: handle location wrappers

2018-01-05 Thread Jason Merrill
On 12/22/2017 02:10 PM, David Malcolm wrote: You describe the types needing to match "closely enough" (as opposed to *exactly*), and that may be the key here: what I didn't say in my message above is that the decl is "const" whereas the value isn't. Right, differences in top-level qualifiers do

Re: PING Re: [v3 of PATCH 13/14] c-format.c: handle location wrappers

2018-01-05 Thread Joseph Myers
On Fri, 5 Jan 2018, David Malcolm wrote: > Ping: > https://gcc.gnu.org/ml/gcc-patches/2017-12/msg01494.html OK. -- Joseph S. Myers jos...@codesourcery.com

PING Re: [v3 of PATCH 13/14] c-format.c: handle location wrappers

2018-01-05 Thread David Malcolm
Ping: https://gcc.gnu.org/ml/gcc-patches/2017-12/msg01494.html (FWIW, the only other patch still needing review in the kit is: "[v2 of PATCH 03/14] C++: add location_t wrapper nodes during parsing (minimal impl)" https://gcc.gnu.org/ml/gcc-patches/2017-12/msg01594.html ) On Fri, 2017-1

[v3 of PATCH 13/14] c-format.c: handle location wrappers

2017-12-22 Thread David Malcolm
On Thu, 2017-12-21 at 00:00 -0500, Jason Merrill wrote: > On Wed, Dec 20, 2017 at 12:33 PM, David Malcolm > wrote: > > On Tue, 2017-12-19 at 14:55 -0500, Jason Merrill wrote: > > > On 12/17/2017 11:29 AM, David Malcolm wrote: > > > > On Mon, 2017-12-11 at 18:45 -0500, Jason Merrill wrote: > > > >

Re: [v2 of PATCH 13/14] c-format.c: handle location wrappers

2017-12-20 Thread Jason Merrill
On Wed, Dec 20, 2017 at 12:33 PM, David Malcolm wrote: > On Tue, 2017-12-19 at 14:55 -0500, Jason Merrill wrote: >> On 12/17/2017 11:29 AM, David Malcolm wrote: >> > On Mon, 2017-12-11 at 18:45 -0500, Jason Merrill wrote: >> > > On 11/10/2017 04:45 PM, David Malcolm wrote: >> > > > + STRIP_ANY_LO

Re: [v2 of PATCH 13/14] c-format.c: handle location wrappers

2017-12-20 Thread David Malcolm
On Tue, 2017-12-19 at 14:55 -0500, Jason Merrill wrote: > On 12/17/2017 11:29 AM, David Malcolm wrote: > > On Mon, 2017-12-11 at 18:45 -0500, Jason Merrill wrote: > > > On 11/10/2017 04:45 PM, David Malcolm wrote: > > > > + STRIP_ANY_LOCATION_WRAPPER (format_tree); > > > > + > > > > if (VAR_

Re: [v2 of PATCH 13/14] c-format.c: handle location wrappers

2017-12-19 Thread Jason Merrill
On 12/17/2017 11:29 AM, David Malcolm wrote: On Mon, 2017-12-11 at 18:45 -0500, Jason Merrill wrote: On 11/10/2017 04:45 PM, David Malcolm wrote: + STRIP_ANY_LOCATION_WRAPPER (format_tree); + if (VAR_P (format_tree)) { /* Pull out a constant value if the front end didn'

[v2 of PATCH 13/14] c-format.c: handle location wrappers

2017-12-17 Thread David Malcolm
On Mon, 2017-12-11 at 18:45 -0500, Jason Merrill wrote: > On 11/10/2017 04:45 PM, David Malcolm wrote: > > gcc/c-family/ChangeLog: > >* c-format.c (check_format_arg): Strip any location wrapper > > around > >format_tree. > > --- > >gcc/c-family/c-format.c | 9 - > >1

Re: [PATCH 13/14] c-format.c: handle location wrappers

2017-12-11 Thread Jason Merrill
On 11/10/2017 04:45 PM, David Malcolm wrote: gcc/c-family/ChangeLog: * c-format.c (check_format_arg): Strip any location wrapper around format_tree. --- gcc/c-family/c-format.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gcc/c-family/c-format.c b

[PATCH 13/14] c-format.c: handle location wrappers

2017-11-10 Thread David Malcolm
gcc/c-family/ChangeLog: * c-format.c (check_format_arg): Strip any location wrapper around format_tree. --- gcc/c-family/c-format.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gcc/c-family/c-format.c b/gcc/c-family/c-format.c index 164d035..6b436ec 1