RE: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-05-02 Thread Greta Yorsh
gt; -Original Message- > From: Mike Stump [mailto:mikest...@comcast.net] > Sent: 30 April 2012 17:09 > To: Dodji Seketeli > Cc: Gabriel Dos Reis; GCC Patches; Tom Tromey; Jason Merrill; Paolo > Carlini; Benjamin De Kosnik > Subject: Re: [PATCH 12/13] Adjust relevant test ca

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-30 Thread Mike Stump
On Apr 29, 2012, at 10:38 AM, Dodji Seketeli wrote: > While bootstrapping the tree again, it appeared that an output > regression of the objc test objc.dg/foreach-7.m flew below my radar. > This looks fairly obvious to me, but I am CC-ing Mike Stump, just in > case. That's fine.

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-30 Thread Gabriel Dos Reis
It is still OK :-) On Mon, Apr 30, 2012 at 1:22 AM, Dodji Seketeli wrote: > Dodji Seketeli writes: > >> Gabriel Dos Reis writes: >> >>> OK. >> >> Thank you. >> >> While bootstrapping the tree again, it appeared that an output >> regression of the objc test objc.dg/foreach-7.m flew below my rada

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-29 Thread Dodji Seketeli
Dodji Seketeli writes: > Gabriel Dos Reis writes: > >> OK. > > Thank you. > > While bootstrapping the tree again, it appeared that an output > regression of the objc test objc.dg/foreach-7.m flew below my radar. > > It's one of those typical cases where the first location pointed to by > the dia

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-29 Thread Dodji Seketeli
Gabriel Dos Reis writes: > OK. Thank you. While bootstrapping the tree again, it appeared that an output regression of the objc test objc.dg/foreach-7.m flew below my radar. It's one of those typical cases where the first location pointed to by the diagnostics points into the definition of a m

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-25 Thread Benjamin Kosnik
Hey hey! Looking good Dodji. Can't wait to use this stuff. > There are so many libstdc++ tests that were failing because of that > benign issue that I preferred to just run them with > -ftrack-macro-expansion diabled, after inspecting each of them to be > sure there was nothing more serious under

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 9:16 AM, Dodji Seketeli wrote: > Even after all the patches I have already submitted for this > -ftrack-macro-expansion business, some test cases where errors happens > on tokens that are defined in macros see their output change in an > incompatible way, when you run them

[PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-25 Thread Dodji Seketeli
Even after all the patches I have already submitted for this -ftrack-macro-expansion business, some test cases where errors happens on tokens that are defined in macros see their output change in an incompatible way, when you run them with or without -ftrack-macro-expansion. I think this is expect