Re: [PATCH 10/13] OpenACC 2.6 deep copy: Fortran front-end parts

2019-12-20 Thread Tobias Burnus
Hi Julian, thanks for the patch and the post-review fixes. (The revised patch was committed as r279628. And I have committed a few minor follow-up improvements.) I still have an issues with the following. On 12/18/19 11:51 PM, Tobias Burnus wrote: +  /* Disallow duplicate bare variable

[committed] Improve is-coindexed check for OpenACC/OpenMP (was: [PATCH 10/13] OpenACC 2.6 deep copy: Fortran front-end parts)

2019-12-20 Thread Tobias Burnus
Julian has committed that patch as Rev. 279628. Follow up regarding coarrays: I had proposed to use 'gfc_is_coindexed' instead of only checking the rightmost array reference. However, it turned out that this check comes too late. (As did the check before Julian's patch.) Namely, when checkin

[patch,committed] Fix testsuite-fallout of OpenACC deep-copy patch (was: [PATCH 10/13] OpenACC 2.6 deep copy: Fortran front-end parts)

2019-12-20 Thread Tobias Burnus
Julian's patch (r279628) removed several now obsolete dg-errors about ALLOCATABLE and POINTER. But seemingly, one was missed and two (for no_create) were added between posting the patch and committing that patch. Committed the attached patch as obvious in Rev.279634. Cheers, Tobias Index:

Re: [PATCH 10/13] OpenACC 2.6 deep copy: Fortran front-end parts

2019-12-18 Thread Tobias Burnus
On 12/18/19 7:04 AM, Julian Brown wrote: This part contains the Fortran front-end support for parsing the new attach and detach clauses, as well as derived-type members on other data-movement clauses (copyin, copyout, etc.). I browsed the patch and it looks mostly fine to me. However, I do have

[PATCH 10/13] OpenACC 2.6 deep copy: Fortran front-end parts

2019-12-17 Thread Julian Brown
This patch has been broken out of the "OpenACC 2.6 manual deep copy support" patch, last posted here: https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02376.html This part contains the Fortran front-end support for parsing the new attach and detach clauses, as well as derived-type members on other