Re: [PATCH 1/8] ipa: Fix jump function copying

2024-11-14 Thread Jan Hubicka
> Hello Josef, > > On Tue, Nov 05 2024, Josef Melcr wrote: > > Hi! > > > > On 11/5/24 12:06, Martin Jambor wrote: > >> +/* Copy information from SRC_JF to DST_JF which correstpond to call graph > >> edges > >> + SRC and DST. */ > >> + > >> +static void > >> +ipa_duplicate_jump_function (cgraph

Re: [PATCH 1/8] ipa: Fix jump function copying

2024-11-14 Thread Martin Jambor
Hello Josef, On Tue, Nov 05 2024, Josef Melcr wrote: > Hi! > > On 11/5/24 12:06, Martin Jambor wrote: >> +/* Copy information from SRC_JF to DST_JF which correstpond to call graph >> edges >> + SRC and DST. */ >> + >> +static void >> +ipa_duplicate_jump_function (cgraph_edge *src, cgraph_edge

Re: [PATCH 1/8] ipa: Fix jump function copying

2024-11-05 Thread Jan Hubicka
> Bootstrapped and tested on x86_64-linux, the whole patch series has > additionally passed LTO and profiled-LTO bootstrap on the same platform > and a bootstrap and testsuite on ppc64-linux. Aarch64-linux bootstrap > and testing is in progress. Because we have agreed with Honza this is > necessa

Re: [PATCH 1/8] ipa: Fix jump function copying

2024-11-05 Thread Josef Melcr
Hi! On 11/5/24 12:06, Martin Jambor wrote: +/* Copy information from SRC_JF to DST_JF which correstpond to call graph edges + SRC and DST. */ + +static void +ipa_duplicate_jump_function (cgraph_edge *src, cgraph_edge *dst, +ipa_jump_func *src_jf, ipa_jump_func *dst

[PATCH 1/8] ipa: Fix jump function copying

2024-11-05 Thread Martin Jambor
Hi, when reviewing various IPA bits and pieces I have discovered two embarrassing problems with jump function duplication. First, aggregate jump function vector copying contained a pasto where the source is the (empty) destination vector and so no aggregate jump functions ever got copied to jump