Re: [PATCH 1/4] i386: Ignore regparm attribute and warn for it in 64-bit mode

2025-07-29 Thread Alexander Monakov
Hello. > > OK. > > BTW: How do you plan to go forward with these patches? > > If you don't have compyright assignment then we need your > Signed-off-by: on the patches, please read "Legal Prerequisites" of > https://gcc.gnu.org/contribute.html . Also, Like myself, Artemiy is covered by company-

Re: [PATCH 1/4] i386: Ignore regparm attribute and warn for it in 64-bit mode

2025-07-29 Thread Uros Bizjak
On Tue, Jul 29, 2025 at 6:58 PM Uros Bizjak wrote: > > On Tue, Jul 29, 2025 at 5:04 PM wrote: > > > > On 2025-07-25 11:18, Uros Bizjak wrote: > > > On Thu, Jul 24, 2025 at 5:35 PM Artemiy Granat > > > wrote: > > >> > > >> gcc/testsuite/ChangeLog: > > >> > > >> * g++.dg/abi/regparm1.C: Us

Re: [PATCH 1/4] i386: Ignore regparm attribute and warn for it in 64-bit mode

2025-07-29 Thread Uros Bizjak
On Tue, Jul 29, 2025 at 5:04 PM wrote: > > On 2025-07-25 11:18, Uros Bizjak wrote: > > On Thu, Jul 24, 2025 at 5:35 PM Artemiy Granat > > wrote: > >> > >> gcc/testsuite/ChangeLog: > >> > >> * g++.dg/abi/regparm1.C: Use regparm attribute only if not in > >> 64-bit mode. > >>

Re: [PATCH 1/4] i386: Ignore regparm attribute and warn for it in 64-bit mode

2025-07-29 Thread a . granat
On 2025-07-25 11:18, Uros Bizjak wrote: On Thu, Jul 24, 2025 at 5:35 PM Artemiy Granat wrote: gcc/testsuite/ChangeLog: * g++.dg/abi/regparm1.C: Use regparm attribute only if not in 64-bit mode. * gcc.target/i386/20020224-1.c: Likewise. * gcc.target/i386/pr10378

Re: [PATCH 1/4] i386: Ignore regparm attribute and warn for it in 64-bit mode

2025-07-25 Thread Uros Bizjak
On Thu, Jul 24, 2025 at 5:35 PM Artemiy Granat wrote: > > The regparm attribute does not affect code generation on x86-64 target. > Despite this, regparm was accepted silently, unlike other calling > convention attributes handled in the ix86_handle_cconv_attribute > function. > > Due to lack of di

[PATCH 1/4] i386: Ignore regparm attribute and warn for it in 64-bit mode

2025-07-24 Thread Artemiy Granat
The regparm attribute does not affect code generation on x86-64 target. Despite this, regparm was accepted silently, unlike other calling convention attributes handled in the ix86_handle_cconv_attribute function. Due to lack of diagnostics, Linux kernel attempted to specify regparm(0) on vmread_er