Re: [PATCH 1/2] handwritten part of patch

2013-05-31 Thread Mike Stump
I like the idea that someone reviews the end destination you want to get to, and the general path you want to use to get there, and then just pre-approve the entire concept. :-) I think I like the end destination; the path you have chosen is slightly different from the one I might have chosen,

Re: [PATCH 1/2] handwritten part of patch

2013-05-31 Thread David Malcolm
On Wed, 2013-05-29 at 10:06 +0200, Richard Biener wrote: > On Tue, May 28, 2013 at 8:04 PM, David Malcolm wrote: > > On Mon, 2013-05-27 at 15:38 +0200, Richard Biener wrote: > >> On Sat, May 25, 2013 at 3:02 PM, David Malcolm wrote: > >> > Eliminate all direct references to "cfun" from ma

Re: [PATCH 1/2] handwritten part of patch

2013-05-29 Thread Richard Biener
On Tue, May 28, 2013 at 8:04 PM, David Malcolm wrote: > On Mon, 2013-05-27 at 15:38 +0200, Richard Biener wrote: >> On Sat, May 25, 2013 at 3:02 PM, David Malcolm wrote: >> > Eliminate all direct references to "cfun" from macros in >> > basic-block.h and introduce access methods t

Re: [PATCH 1/2] handwritten part of patch

2013-05-28 Thread David Malcolm
On Mon, 2013-05-27 at 15:38 +0200, Richard Biener wrote: > On Sat, May 25, 2013 at 3:02 PM, David Malcolm wrote: > > Eliminate all direct references to "cfun" from macros in > > basic-block.h and introduce access methods to control_flow_graph > > > > * basic-block.h (contro

Re: [PATCH 1/2] handwritten part of patch

2013-05-27 Thread Richard Biener
On Sat, May 25, 2013 at 3:02 PM, David Malcolm wrote: > Eliminate all direct references to "cfun" from macros in > basic-block.h and introduce access methods to control_flow_graph > > * basic-block.h (control_flow_graph::get_basic_block_by_idx): New > accessor metho

[PATCH 1/2] handwritten part of patch

2013-05-25 Thread David Malcolm
Eliminate all direct references to "cfun" from macros in basic-block.h and introduce access methods to control_flow_graph * basic-block.h (control_flow_graph::get_basic_block_by_idx): New accessor methods. (control_flow_graph::get_entry_block): New method.