Re: [PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-21 Thread Joel Brobecker
> Changelog libiberty/ > * pex-win32.c (argv_to_cmdline): Don't quote > args unnecessarily Some minor comments... > > diff --git a/libiberty/pex-win32.c b/libiberty/pex-win32.c > > index eae72c5..775b53c 100644 > > --- a/libiberty/pex-win32.c > > +++ b/libiberty/pex-win32.c > > @@ -34

Re: [PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-19 Thread Eli Zaretskii
> Date: Sat, 19 Apr 2014 16:23:33 -0400 (EDT) > From: Kai Tietz > Cc: gcc-patches@gcc.gnu.org, ktiet...@gmail.com, > "binut...@sourceware.org Development" , > gdb-patc...@sourceware.org > > > + /* We only quote arguments that contain spaces, \n \t \v or " > > characters > >

Re: [PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-19 Thread Kai Tietz
Hello Ray, Patches to libiberty need to be cross-posted to binutils, gdb, and gcc ML. I did so for you now. - Original Message - > We only quote arguments that contain spaces, \n \t \v > or " characters to prevent wasting 2 characters per > argument of the CreateProcess() 32,768 limit.

[PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-19 Thread Ray Donnelly
We only quote arguments that contain spaces, \n \t \v or " characters to prevent wasting 2 characters per argument of the CreateProcess() 32,768 limit. libiberty/ * pex-win32.c (argv_to_cmdline): Don't quote args unnecessarily --- libiberty/ChangeLog | 5 + libiberty/pex-wi