Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Maxim Ostapenko
On 24/11/15 15:17, Christophe Lyon wrote: On 24 November 2015 at 12:57, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 02:55:26PM +0300, Maxim Ostapenko wrote: diff --git a/libsanitizer/ChangeLog b/libsanitizer/ChangeLog index c392c57..895d3bd 100644 --- a/libsanitizer/ChangeLog +++ b/libsanitiz

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Christophe Lyon
On 24 November 2015 at 12:57, Jakub Jelinek wrote: > On Tue, Nov 24, 2015 at 02:55:26PM +0300, Maxim Ostapenko wrote: >> diff --git a/libsanitizer/ChangeLog b/libsanitizer/ChangeLog >> index c392c57..895d3bd 100644 >> --- a/libsanitizer/ChangeLog >> +++ b/libsanitizer/ChangeLog >> @@ -1,5 +1,10 @@

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Yury Gribov
On 11/24/2015 02:55 PM, Maxim Ostapenko wrote: On 24/11/15 14:27, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 12:23:05PM +0100, Christophe Lyon wrote: On 24 November 2015 at 12:12, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 12:08:13PM +0100, Christophe Lyon wrote: Sure. I had a build in p

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Jakub Jelinek
On Tue, Nov 24, 2015 at 02:55:26PM +0300, Maxim Ostapenko wrote: > diff --git a/libsanitizer/ChangeLog b/libsanitizer/ChangeLog > index c392c57..895d3bd 100644 > --- a/libsanitizer/ChangeLog > +++ b/libsanitizer/ChangeLog > @@ -1,5 +1,10 @@ > 2015-11-24 Maxim Ostapenko > > + * include/sys

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Maxim Ostapenko
On 24/11/15 14:27, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 12:23:05PM +0100, Christophe Lyon wrote: On 24 November 2015 at 12:12, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 12:08:13PM +0100, Christophe Lyon wrote: Sure. I had a build in progress with your proposed patch, but it didn't

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Jakub Jelinek
On Tue, Nov 24, 2015 at 12:23:05PM +0100, Christophe Lyon wrote: > On 24 November 2015 at 12:12, Jakub Jelinek wrote: > > On Tue, Nov 24, 2015 at 12:08:13PM +0100, Christophe Lyon wrote: > >> > Sure. > >> > I had a build in progress with your proposed patch, but it didn't > >> > complete before yo

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Christophe Lyon
On 24 November 2015 at 12:12, Jakub Jelinek wrote: > On Tue, Nov 24, 2015 at 12:08:13PM +0100, Christophe Lyon wrote: >> > Sure. >> > I had a build in progress with your proposed patch, but it didn't >> > complete before you committed :-) >> > >> >> So... it still does not work for me. I re-tried

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Jakub Jelinek
On Tue, Nov 24, 2015 at 12:08:13PM +0100, Christophe Lyon wrote: > > Sure. > > I had a build in progress with your proposed patch, but it didn't > > complete before you committed :-) > > > > So... it still does not work for me. I re-tried several times, made sure I had > everything cleanup before

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Christophe Lyon
On 24 November 2015 at 10:21, Christophe Lyon wrote: > On 24 November 2015 at 09:58, Maxim Ostapenko > wrote: >> On 24/11/15 11:38, Jakub Jelinek wrote: >>> >>> On Tue, Nov 24, 2015 at 11:36:20AM +0300, Maxim Ostapenko wrote: Ok, does it look better now? >>> >>> Sure, this is ok for tru

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Christophe Lyon
On 24 November 2015 at 09:58, Maxim Ostapenko wrote: > On 24/11/15 11:38, Jakub Jelinek wrote: >> >> On Tue, Nov 24, 2015 at 11:36:20AM +0300, Maxim Ostapenko wrote: >>> >>> Ok, does it look better now? >> >> Sure, this is ok for trunk. >> >>> diff --git a/libsanitizer/ChangeLog b/libsanitizer/Cha

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Maxim Ostapenko
On 24/11/15 11:38, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 11:36:20AM +0300, Maxim Ostapenko wrote: Ok, does it look better now? Sure, this is ok for trunk. diff --git a/libsanitizer/ChangeLog b/libsanitizer/ChangeLog index b97fc7d..c392c57 100644 --- a/libsanitizer/ChangeLog +++ b/libsa

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Jakub Jelinek
On Tue, Nov 24, 2015 at 11:36:20AM +0300, Maxim Ostapenko wrote: > Ok, does it look better now? Sure, this is ok for trunk. > diff --git a/libsanitizer/ChangeLog b/libsanitizer/ChangeLog > index b97fc7d..c392c57 100644 > --- a/libsanitizer/ChangeLog > +++ b/libsanitizer/ChangeLog > @@ -1,3 +1,7 @

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Maxim Ostapenko
On 24/11/15 11:25, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 10:51:05AM +0300, Maxim Ostapenko wrote: Ok, I posted a fix to upstream (http://reviews.llvm.org/D14921) yesterday, but it's still not reviewed. So, I'm wondering if I should fix the issue locally? Attaching proposed fix following J

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Jakub Jelinek
On Tue, Nov 24, 2015 at 10:51:05AM +0300, Maxim Ostapenko wrote: > Ok, I posted a fix to upstream (http://reviews.llvm.org/D14921) yesterday, > but it's still not reviewed. So, I'm wondering if I should fix the issue > locally? > Attaching proposed fix following Jakub's suggestion. > > Christophe

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Maxim Ostapenko
On 23/11/15 16:24, Jakub Jelinek wrote: On Mon, Nov 23, 2015 at 04:21:34PM +0300, Maxim Ostapenko wrote: Yeah, right. I've asked about kernel headers just to make sure I correctly understand the issue. Actually, I see such code in lib/sanitizer_common/sanitizer_platform_limits_posix.cc: #if de

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 04:21:34PM +0300, Maxim Ostapenko wrote: > Yeah, right. I've asked about kernel headers just to make sure I correctly > understand the issue. > > Actually, I see such code in > lib/sanitizer_common/sanitizer_platform_limits_posix.cc: > > #if defined(PTRACE_GETVFPREGS) && d

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Maxim Ostapenko
On 23/11/15 16:00, Christophe Lyon wrote: On 23 November 2015 at 13:41, Jakub Jelinek wrote: On Mon, Nov 23, 2015 at 03:33:57PM +0300, Maxim Ostapenko wrote: + Adhemerval Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain ARM_VFPREGS_SIZE. Do you use old kernel version

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Christophe Lyon
On 23 November 2015 at 13:41, Jakub Jelinek wrote: > On Mon, Nov 23, 2015 at 03:33:57PM +0300, Maxim Ostapenko wrote: >> + Adhemerval >> >> Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain >> ARM_VFPREGS_SIZE. Do you use old kernel version? > Yes, I do use old kernel hea

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 03:33:57PM +0300, Maxim Ostapenko wrote: > + Adhemerval > > Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain > ARM_VFPREGS_SIZE. Do you use old kernel version? Unlike LLVM, we do care to support older kernel headers. So, if it is say a define, you

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Maxim Ostapenko
+ Adhemerval Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain ARM_VFPREGS_SIZE. Do you use old kernel version? -Maxim On 23/11/15 15:16, Christophe Lyon wrote: On 23 November 2015 at 09:07, Jakub Jelinek wrote: On Mon, Nov 23, 2015 at 10:46:33AM +0300, Maxim Ostap

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Christophe Lyon
On 23 November 2015 at 09:07, Jakub Jelinek wrote: > On Mon, Nov 23, 2015 at 10:46:33AM +0300, Maxim Ostapenko wrote: >> Index: libsanitizer/configure.ac >> === >> --- libsanitizer/configure.ac (revision 230597) >> +++ libsanitizer/co

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 10:46:33AM +0300, Maxim Ostapenko wrote: > Index: libsanitizer/configure.ac > === > --- libsanitizer/configure.ac (revision 230597) > +++ libsanitizer/configure.ac (working copy) > @@ -136,6 +136,12 @@ > esac >