Re: [PATCH 1/2] C++: avoid partial duplicate implementation of cp_parser_error

2017-10-12 Thread David Malcolm
On Wed, 2017-10-11 at 17:18 -0400, Jason Merrill wrote: > On Tue, Sep 26, 2017 at 9:56 AM, David Malcolm > wrote: > > In r251026 (aka 3fe34694f0990d1d649711ede0326497f8a849dc, > > "C/C++: show pertinent open token when missing a close token") > > I copied part of cp_parser_error into cp_parser_req

Re: [PATCH 1/2] C++: avoid partial duplicate implementation of cp_parser_error

2017-10-11 Thread Jason Merrill
On Tue, Sep 26, 2017 at 9:56 AM, David Malcolm wrote: > In r251026 (aka 3fe34694f0990d1d649711ede0326497f8a849dc, > "C/C++: show pertinent open token when missing a close token") > I copied part of cp_parser_error into cp_parser_required_error, > leading to duplication of code. > > This patch elim

PING: Re: [PATCH 1/2] C++: avoid partial duplicate implementation of cp_parser_error

2017-10-11 Thread David Malcolm
Ping On Tue, 2017-09-26 at 09:56 -0400, David Malcolm wrote: > In r251026 (aka 3fe34694f0990d1d649711ede0326497f8a849dc, > "C/C++: show pertinent open token when missing a close token") > I copied part of cp_parser_error into cp_parser_required_error, > leading to duplication of code. > > This pa

[PATCH 1/2] C++: avoid partial duplicate implementation of cp_parser_error

2017-09-26 Thread David Malcolm
In r251026 (aka 3fe34694f0990d1d649711ede0326497f8a849dc, "C/C++: show pertinent open token when missing a close token") I copied part of cp_parser_error into cp_parser_required_error, leading to duplication of code. This patch eliminates this duplication by merging the two copies of the code into