Re: [PATCH 1/1] RISC-V: Fix canonical extension order (K and J)

On 2022/05/19 12:40, Nelson Chu wrote: > Seems like gcc and llvm have already committed this patch, so LGTM, committed. Sorry, the same change is applied to LLVM but not yet on GCC (because I forgot to add "Signed-off-by" line). I sent PATCH v2 to gcc-patches today so that would be okay. On PATC

Re: [PATCH 1/1] RISC-V: Fix canonical extension order (K and J)

> > and so it doesn't make > > sense to mandate any particular ordering. > > No. It affects Z* extension ordering... +1, we really need the order in ISA spec so that we could know the canonical order for z* exts.

Re: [PATCH 1/1] RISC-V: Fix canonical extension order (K and J)

Hello, > Neither K nor J is an extension that exists, That is correct. > and so it doesn't make > sense to mandate any particular ordering. No. It affects Z* extension ordering... On 2022/04/24 14:36, Andrew Waterman wrote: > Neither K nor J is an extension that exists, and so it doesn't make

Re: [PATCH 1/1] RISC-V: Fix canonical extension order (K and J)

Neither K nor J is an extension that exists, and so it doesn't make sense to mandate any particular ordering. The better change would be to delete the letters `k' and `j' from that string, so that we aren't enforcing constraints that don't serve a useful purpose. cf. https://github.com/riscv/ris

[PATCH 1/1] RISC-V: Fix canonical extension order (K and J)

This commit fixes canonical extension order to follow the RISC-V ISA Manual draft-20210402-1271737 or later. gcc/ChangeLog: * common/config/riscv/riscv-common.cc (riscv_supported_std_ext): Fix "K" extension prefix to be placed before "J". --- gcc/common/config/riscv/riscv-common.