Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-07-17 Thread Thomas Schwinge
Hi Julian! On 2020-07-16T22:21:43+0100, Julian Brown wrote: > On Thu, 16 Jul 2020 11:35:23 +0200 > Thomas Schwinge wrote: >> On 2020-06-26T11:20:40+0200, I wrote: >> > On 2019-12-17T22:03:47-0800, Julian Brown >> > wrote: >> >> This part contains the libgomp runtime support for the >> >> GOMP_M

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-07-16 Thread Julian Brown
On Thu, 16 Jul 2020 11:35:23 +0200 Thomas Schwinge wrote: > Hi Julian! > > Ping. > > On 2020-06-26T11:20:40+0200, I wrote: > > On 2019-12-17T22:03:47-0800, Julian Brown > > wrote: > >> This part contains the libgomp runtime support for the > >> GOMP_MAP_ATTACH and GOMP_MAP_DETACH mapping kin

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-07-16 Thread Thomas Schwinge
Hi Julian! Ping. On 2020-06-26T11:20:40+0200, I wrote: > On 2019-12-17T22:03:47-0800, Julian Brown wrote: >> This part contains the libgomp runtime support for the GOMP_MAP_ATTACH and >> GOMP_MAP_DETACH mapping kinds (etc.), as introduced by the front-end >> patches following in this series. > >

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-06-30 Thread Thomas Schwinge
Hi Julian! On 2019-12-17T22:03:47-0800, Julian Brown wrote: > This part contains the libgomp runtime support for the GOMP_MAP_ATTACH and > GOMP_MAP_DETACH mapping kinds (etc.), as introduced by the front-end > patches following in this series. > --- a/libgomp/target.c > +++ b/libgomp/target.c >

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-06-26 Thread Thomas Schwinge
Hi Julian! On 2019-12-17T22:03:47-0800, Julian Brown wrote: > This part contains the libgomp runtime support for the GOMP_MAP_ATTACH and > GOMP_MAP_DETACH mapping kinds (etc.), as introduced by the front-end > patches following in this series. > --- a/libgomp/target.c > +++ b/libgomp/target.c >

Re: OpenACC 'attach'/'detach' has no business affecting user-visible reference counting (was: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts)

2020-06-18 Thread Julian Brown
Hi! On Tue, 9 Jun 2020 12:41:21 +0200 Thomas Schwinge wrote: > Hi Julian! > > On 2020-06-05T21:31:08+0100, Julian Brown > wrote: > > On Fri, 5 Jun 2020 13:17:09 +0200 > > Thomas Schwinge wrote: > >> On 2019-12-17T21:03:47-0800, Julian Brown > >> wrote: > >> > This part contains the libgo

Re: OpenACC 'attach'/'detach' has no business affecting user-visible reference counting (was: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts)

2020-06-09 Thread Julian Brown
On Tue, 9 Jun 2020 12:41:21 +0200 Thomas Schwinge wrote: > Hi Julian! > > On 2020-06-05T21:31:08+0100, Julian Brown > wrote: > >> For the OpenACC runtime API 'acc_attach' etc. routines they don't, > >> so what's the conceptual reason that for the corresponding OpenACC > >> directive variants, '

OpenACC 'attach'/'detach' has no business affecting user-visible reference counting (was: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts)

2020-06-09 Thread Thomas Schwinge
Hi Julian! On 2020-06-05T21:31:08+0100, Julian Brown wrote: > On Fri, 5 Jun 2020 13:17:09 +0200 > Thomas Schwinge wrote: >> On 2019-12-17T21:03:47-0800, Julian Brown >> wrote: >> > This part contains the libgomp runtime support for the >> > GOMP_MAP_ATTACH and GOMP_MAP_DETACH mapping kinds >> >

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-06-05 Thread Julian Brown
On Fri, 5 Jun 2020 13:17:09 +0200 Thomas Schwinge wrote: > Hi Julian! > > On 2019-12-17T21:03:47-0800, Julian Brown > wrote: > > This part contains the libgomp runtime support for the > > GOMP_MAP_ATTACH and GOMP_MAP_DETACH mapping kinds > > > --- a/libgomp/target.c > > +++ b/libgomp/target.

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-06-05 Thread Julian Brown
On Fri, 5 Jun 2020 12:39:46 +0200 Thomas Schwinge wrote: > Hi Julian! > > On 2019-12-17T22:03:47-0800, Julian Brown > wrote: > > This part contains the libgomp runtime support for the > > GOMP_MAP_ATTACH and GOMP_MAP_DETACH mapping kinds > > > --- a/libgomp/oacc-mem.c > > +++ b/libgomp/oacc-

[OpenACC 'exit data'] Strip 'GOMP_MAP_STRUCT' mappings (was: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts)

2020-06-05 Thread Thomas Schwinge
Hi! On 2020-05-20T11:37:35+0200, I wrote: > Moving this over, from the "Fix component mappings with derived types for > OpenACC" thread, > , where > you propose to change this 'GOMP_MAP_STRUCT' handling code: > > On 2019-12-17T22:03

[OpenACC 'exit data'] Simplify 'GOMP_MAP_STRUCT' handling (was: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts)

2020-06-05 Thread Thomas Schwinge
Hi! On 2020-05-20T11:37:35+0200, I wrote: > Moving this over, from the "Fix component mappings with derived types for > OpenACC" thread, > , where > you propose to change this 'GOMP_MAP_STRUCT' handling code: > > On 2019-12-17T22:03

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-06-05 Thread Thomas Schwinge
Hi Julian! On 2019-12-17T21:03:47-0800, Julian Brown wrote: > This part contains the libgomp runtime support for the GOMP_MAP_ATTACH and > GOMP_MAP_DETACH mapping kinds > --- a/libgomp/target.c > +++ b/libgomp/target.c > @@ -1203,6 +1211,32 @@ gomp_map_vars_internal (struct gomp_device_descr >

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-06-05 Thread Thomas Schwinge
Hi Julian! On 2019-12-17T22:03:47-0800, Julian Brown wrote: > This part contains the libgomp runtime support for the GOMP_MAP_ATTACH and > GOMP_MAP_DETACH mapping kinds > --- a/libgomp/oacc-mem.c > +++ b/libgomp/oacc-mem.c > @@ -1018,6 +1033,33 @@ goacc_exit_data_internal (struct gomp_device_de

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-06-04 Thread Thomas Schwinge
Hi! On 2019-12-17T22:03:47-0800, Julian Brown wrote: > This part contains the libgomp runtime support for the GOMP_MAP_ATTACH and > GOMP_MAP_DETACH mapping kinds (etc.) > --- a/libgomp/oacc-mem.c > +++ b/libgomp/oacc-mem.c > @@ -1075,6 +1119,39 @@ goacc_exit_data_internal (struct gomp_device_de

[OpenACC] Repair/restore 'is_tgt_unmapped' checking (was: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts)

2020-06-04 Thread Thomas Schwinge
Hi! On 2020-05-20T20:11:00+0100, Julian Brown wrote: > On Wed, 20 May 2020 16:52:02 +0200 > Thomas Schwinge wrote: >> On 2019-12-17T22:03:47-0800, Julian Brown >> wrote: >> > --- a/libgomp/oacc-mem.c >> > +++ b/libgomp/oacc-mem.c >> >> > static int >> > -find_group_last (int pos, size_t mapnum

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-05-20 Thread Julian Brown
On Wed, 20 May 2020 16:52:02 +0200 Thomas Schwinge wrote: > Hi! > > On 2019-12-17T22:03:47-0800, Julian Brown > wrote: > > --- a/libgomp/oacc-mem.c > > +++ b/libgomp/oacc-mem.c > > > static int > > -find_group_last (int pos, size_t mapnum, unsigned short *kinds) > > +find_group_last (int po

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-05-20 Thread Thomas Schwinge
Hi! On 2019-12-17T22:03:47-0800, Julian Brown wrote: > --- a/libgomp/oacc-mem.c > +++ b/libgomp/oacc-mem.c > static int > -find_group_last (int pos, size_t mapnum, unsigned short *kinds) > +find_group_last (int pos, size_t mapnum, size_t *sizes, unsigned short > *kinds) > { >unsigned char

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-05-20 Thread Thomas Schwinge
Hi Julian! Moving this over, from the "Fix component mappings with derived types for OpenACC" thread, , where you propose to change this 'GOMP_MAP_STRUCT' handling code: On 2019-12-17T22:03:47-0800, Julian Brown wrote: > --- a/lib

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-01-03 Thread Julian Brown
Hi, On Sun, 22 Dec 2019 00:01:10 +0100 Thomas Schwinge wrote: > I had intentionally left out this assignment in my "In > 'libgomp/target.c', 'struct splay_tree_key_s', use 'struct > splay_tree_aux' for infrequently-used or API-specific data" patch, > <87k16uykb7.fsf@euler.schwinge.homeip.net">ht

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2019-12-21 Thread Thomas Schwinge
Hi! On 2019-12-17T22:03:47-0800, Julian Brown wrote: > This part contains the libgomp runtime support for the GOMP_MAP_ATTACH and > GOMP_MAP_DETACH mapping kinds (etc.), as introduced by the front-end > patches following in this series. This (r279625) regressed the same OpenMP 'omp declare targe

[PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2019-12-17 Thread Julian Brown
This patch has been broken out of the "OpenACC 2.6 manual deep copy support" patch, last posted here: https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02376.html This part contains the libgomp runtime support for the GOMP_MAP_ATTACH and GOMP_MAP_DETACH mapping kinds (etc.), as introduced by the fr