Re: [PATCH 02/25] Propagate address spaces to builtins.

2019-09-04 Thread Kyrill Tkachov
On 9/4/19 3:21 PM, Kyrill Tkachov wrote: On 9/3/19 4:00 PM, Jeff Law wrote: > On 9/3/19 8:01 AM, Kyrill Tkachov wrote: >> Hi all, >> >> On 9/5/18 12:48 PM, a...@codesourcery.com wrote: >>> At present, pointers passed to builtin functions, including atomic >>> operators, >>> are stripped of the

Re: [PATCH 02/25] Propagate address spaces to builtins.

2019-09-04 Thread Kyrill Tkachov
On 9/3/19 4:00 PM, Jeff Law wrote: On 9/3/19 8:01 AM, Kyrill Tkachov wrote: Hi all, On 9/5/18 12:48 PM, a...@codesourcery.com wrote: At present, pointers passed to builtin functions, including atomic operators, are stripped of their address space properties.  This doesn't seem to be delibera

Re: [PATCH 02/25] Propagate address spaces to builtins.

2019-09-03 Thread Andrew Stubbs
On 03/09/2019 15:01, Kyrill Tkachov wrote: Sorry for responding to this so late. I'm testing a rebased version of Richard's OOL atomic patches [1] and am hitting an ICE building the -mabi=ilp32 libgfortran multilib for aarch64-none-elf: I thought Andreas already fixed ILP32. https://gcc.gnu.o

Re: [PATCH 02/25] Propagate address spaces to builtins.

2019-09-03 Thread Jeff Law
On 9/3/19 8:01 AM, Kyrill Tkachov wrote: > Hi all, > > On 9/5/18 12:48 PM, a...@codesourcery.com wrote: >> >> At present, pointers passed to builtin functions, including atomic >> operators, >> are stripped of their address space properties.  This doesn't seem to be >> deliberate, it just omits to

Re: [PATCH 02/25] Propagate address spaces to builtins.

2019-09-03 Thread Kyrill Tkachov
Hi all, On 9/5/18 12:48 PM, a...@codesourcery.com wrote: At present, pointers passed to builtin functions, including atomic operators, are stripped of their address space properties.  This doesn't seem to be deliberate, it just omits to copy them. Not only that, but it forces pointer sizes t

Re: [PATCH 02/25] Propagate address spaces to builtins.

2018-09-24 Thread Andreas Schwab
On Sep 24 2018, Andrew Stubbs wrote: > What should I have done? Make sure you have the ILP32 patches for glibc and kernel. You can get them from the arm/ilp32 branch on sourceware.org and the staging/ilp32-4.17 branch of

Re: [PATCH 02/25] Propagate address spaces to builtins.

2018-09-24 Thread Andrew Stubbs
On 22/09/18 19:51, Andreas Schwab wrote: That breaks aarch64 ILP32. I'm struggling to reproduce this because apparently I don't know how to build aarch64 ILP32. Presumably, in order to be building libgomp this must be an aarch64-linux-gnu toolchain, but when I set --with-abi=ilp32 I can't

Re: [PATCH 02/25] Propagate address spaces to builtins.

2018-09-22 Thread Andreas Schwab
On Sep 05 2018, wrote: > At present, pointers passed to builtin functions, including atomic operators, > are stripped of their address space properties. This doesn't seem to be > deliberate, it just omits to copy them. > > Not only that, but it forces pointer sizes to Pmode, which isn't appropri

Re: [PATCH 02/25] Propagate address spaces to builtins.

2018-09-20 Thread Richard Biener
On Wed, Sep 5, 2018 at 1:50 PM wrote: > > > At present, pointers passed to builtin functions, including atomic operators, > are stripped of their address space properties. This doesn't seem to be > deliberate, it just omits to copy them. > > Not only that, but it forces pointer sizes to Pmode, wh

[PATCH 02/25] Propagate address spaces to builtins.

2018-09-05 Thread ams
At present, pointers passed to builtin functions, including atomic operators, are stripped of their address space properties. This doesn't seem to be deliberate, it just omits to copy them. Not only that, but it forces pointer sizes to Pmode, which isn't appropriate for all address spaces. This