Re: Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-07-07 Thread Fei Gao
On 2024-07-07 22:53  Jeff Law wrote: > > > >On 6/8/24 2:36 PM, Jeff Law wrote: >> >> >> On 6/5/24 8:42 PM, Fei Gao wrote: >> But let's back up and get a good explanation of what the problem is. Based on patch 2/2 it looks like we have lost an assignment to the return register.

Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-07-07 Thread Jeff Law
On 6/8/24 2:36 PM, Jeff Law wrote: On 6/5/24 8:42 PM, Fei Gao wrote: But let's back up and get a good explanation of what the problem is. Based on patch 2/2 it looks like we have lost an assignment to the return register. To someone not familiar with this code, it sounds to me like we've

Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-07-06 Thread Jeff Law
On 6/28/24 4:46 AM, Fei Gao wrote: On 2024-06-09 04:36  Jeff Law wrote: On 6/5/24 8:42 PM, Fei Gao wrote: But let's back up and get a good explanation of what the problem is. Based on patch 2/2 it looks like we have lost an assignment to the return register. To someone not familiar wit

Re: Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-06-28 Thread Fei Gao
On 2024-06-09 04:36  Jeff Law wrote: > > > >On 6/5/24 8:42 PM, Fei Gao wrote: > >>> But let's back up and get a good explanation of what the problem is. >>> Based on patch 2/2 it looks like we have lost an assignment to the >>> return register. >>> >>> To someone not familiar with this code, it so

Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-06-08 Thread Jeff Law
On 6/5/24 8:42 PM, Fei Gao wrote: But let's back up and get a good explanation of what the problem is. Based on patch 2/2 it looks like we have lost an assignment to the return register. To someone not familiar with this code, it sounds to me like we've made a mistake earlier and we're now d

Re: Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-06-05 Thread Fei Gao
On 2024-06-05 21:58  Jeff Law wrote: > > > >On 6/5/24 1:47 AM, Fei Gao wrote: >> >> On 2024-06-05 14:36  Kito Cheng wrote: >>> >>> Thanks for fixing this issue, and I am wondering doest it possible to >>> fix that without introduce target hook? I ask that because...GCC 14 >>> also has this bug, b

Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-06-05 Thread Jeff Law
On 6/5/24 1:47 AM, Fei Gao wrote: On 2024-06-05 14:36  Kito Cheng wrote: Thanks for fixing this issue, and I am wondering doest it possible to fix that without introduce target hook? I ask that because...GCC 14 also has this bug, but I am not sure it's OK to introduce new target hook for r

Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-06-05 Thread Jeff Law
On 6/5/24 12:36 AM, Kito Cheng wrote: Thanks for fixing this issue, and I am wondering doest it possible to fix that without introduce target hook? I ask that because...GCC 14 also has this bug, but I am not sure it's OK to introduce new target hook for release branch? or would you suggest we

Re: Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-06-05 Thread Fei Gao
On 2024-06-05 14:36  Kito Cheng wrote: > >Thanks for fixing this issue, and I am wondering doest it possible to >fix that without introduce target hook? I ask that because...GCC 14 >also has this bug, but I am not sure it's OK to introduce new target >hook for release branch? or would you suggest

Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-06-04 Thread Kito Cheng
Thanks for fixing this issue, and I am wondering doest it possible to fix that without introduce target hook? I ask that because...GCC 14 also has this bug, but I am not sure it's OK to introduce new target hook for release branch? or would you suggest we just revert patch to fix that on GCC 14? O

[PATCH 0/2] fix RISC-V zcmp popretz [PR113715]

2024-06-04 Thread Fei Gao
The 1st patch adds a hook to allow post processing after epilogue inserted. The 2nd one implement the RISC-V hook to solve PR113715. Fei Gao (2): target hooks: allow post processing after epilogue inserted. [RISC-V]: fix zcmp popretz [PR113715]. gcc/config/riscv/riscv.cc |