Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-07-15 Thread Dhruv Chawla
On 08/07/25 18:01, Jan Hubicka wrote: External email: Use caution opening links or attachments Hi Honza, On 8 Jul 2025, at 2:26 am, Jan Hubicka wrote: External email: Use caution opening links or attachments Hi, as discussed also on the autofdo pull request, LLVM solves the same problem

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-07-09 Thread Kugan Vivekanandarajah
Hi Honza, > On 8 Jul 2025, at 10:31 pm, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > >> Hi Honza, >> >>> On 8 Jul 2025, at 2:26 am, Jan Hubicka wrote: >>> >>> External email: Use caution opening links or attachments >>> >>> >>> Hi, >>> as discussed a

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-07-08 Thread Jan Hubicka
> Hi Honza, > > > On 8 Jul 2025, at 2:26 am, Jan Hubicka wrote: > > > > External email: Use caution opening links or attachments > > > > > > Hi, > > as discussed also on the autofdo pull request, LLVM solves the same > > problem using -funique-internal-linkage-names > > https://reviews.llvm.or

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-07-07 Thread Kugan Vivekanandarajah
Hi Honza, > On 8 Jul 2025, at 2:26 am, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > > Hi, > as discussed also on the autofdo pull request, LLVM solves the same > problem using -funique-internal-linkage-names > https://reviews.llvm.org/D73307 > > All non-

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-07-07 Thread Jan Hubicka
Hi, as discussed also on the autofdo pull request, LLVM solves the same problem using -funique-internal-linkage-names https://reviews.llvm.org/D73307 All non-public functions gets theis symbol renamed from .__uniq. Decadic is used since demanglers special case numerical suffixes. In addition debug

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-06-18 Thread Kugan Vivekanandarajah
Hi, > On 17 Jun 2025, at 2:14 am, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > > Hi, >> Introduction >> >> >> Per PR120229 (gcc.gnu.org/PR120229), the auto-profile pass cannot distinguish >> profile information for `function_instance's with

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-06-16 Thread Dhruv Chawla
On 16/06/25 21:44, Jan Hubicka wrote: External email: Use caution opening links or attachments Hi, Introduction Per PR120229 (gcc.gnu.org/PR120229), the auto-profile pass cannot distinguish profile information for `function_instance's with the same base name, when suffixes are re

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-06-16 Thread Jan Hubicka
Hi, > Introduction > > > Per PR120229 (gcc.gnu.org/PR120229), the auto-profile pass cannot distinguish > profile information for `function_instance's with the same base name, when > suffixes are removed. To fix this, source file names should be tracked in the > GCOV file information t

[PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-06-16 Thread dhruvc
From: Dhruv Chawla Introduction Per PR120229 (gcc.gnu.org/PR120229), the auto-profile pass cannot distinguish profile information for `function_instance's with the same base name, when suffixes are removed. To fix this, source file names should be tracked in the GCOV file informatio