Re: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-02-03 Thread Sam James
Toon Moene writes: > On 2/1/24 22:33, Tamar Christina wrote: > >> Bootstrapped Regtested on aarch64-none-linux-gnu and x86_64-pc-linux-gnu no >> issues. >> Also checked both with --enable-lto --with-build-config='bootstrap-O3 >> bootstrap-lto' --enable-multilib >> and --enable-lto --with-buil

Re: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-02-02 Thread Richard Biener
> Am 01.02.2024 um 22:34 schrieb Tamar Christina : > >  >> >>> >>> If the above is correct then I think I understand what you're saying and >>> will update the patch and do some Checks. >> >> Yes, I think that's what I wanted to say. >> > > As discussed: > > Bootstrapped Regtested on aar

Re: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-02-02 Thread Toon Moene
On 2/1/24 22:33, Tamar Christina wrote: Bootstrapped Regtested on aarch64-none-linux-gnu and x86_64-pc-linux-gnu no issues. Also checked both with --enable-lto --with-build-config='bootstrap-O3 bootstrap-lto' --enable-multilib and --enable-lto --with-build-config=bootstrap-O3 --enable-checkin

RE: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-02-01 Thread Tamar Christina
> > > > If the above is correct then I think I understand what you're saying and > > will update the patch and do some Checks. > > Yes, I think that's what I wanted to say. > As discussed: Bootstrapped Regtested on aarch64-none-linux-gnu and x86_64-pc-linux-gnu no issues. Also checked both wit

RE: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-01-30 Thread Richard Biener
On Tue, 30 Jan 2024, Tamar Christina wrote: > > -Original Message- > > From: Richard Biener > > Sent: Tuesday, January 30, 2024 9:51 AM > > To: Tamar Christina > > Cc: gcc-patches@gcc.gnu.org; nd ; j...@ventanamicro.com > > Subject: Re: [PATCH]midd

RE: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-01-30 Thread Tamar Christina
> -Original Message- > From: Richard Biener > Sent: Tuesday, January 30, 2024 9:51 AM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; j...@ventanamicro.com > Subject: Re: [PATCH]middle-end: check memory accesses in the destination block > [PR113588]. >

Re: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-01-30 Thread Richard Biener
On Mon, 29 Jan 2024, Tamar Christina wrote: > Hi All, > > When analyzing loads for early break it was always the intention that > for the exit where things get moved to we only check the loads that can > be reached from the condition. Looking at the code I'm a bit confused that we always move

[PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-01-29 Thread Tamar Christina
Hi All, When analyzing loads for early break it was always the intention that for the exit where things get moved to we only check the loads that can be reached from the condition. However the main loop checks all loads and we skip the destination BB. As such we never actually check the loads re