Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-22 Thread H.J. Lu
On Mon, Jan 21, 2019 at 6:03 PM Joseph Myers wrote: > > On Mon, 21 Jan 2019, H.J. Lu wrote: > > > The testcase at > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88931 > > > > with -frounding-math. __floattisf and __floattidf from libgcc2.c give > > the wrong results for FE_UPWARD and FE_TOW

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Joseph Myers
On Mon, 21 Jan 2019, H.J. Lu wrote: > The testcase at > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88931 > > with -frounding-math. __floattisf and __floattidf from libgcc2.c give > the wrong results for FE_UPWARD and FE_TOWARDZERO. I suggest writing a test that looks something like gcc.dg

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 4:58 PM Joseph Myers wrote: > > On Tue, 22 Jan 2019, Terry Guo wrote: > > > Hi Joseph, > > > > I believe HJ is proposing patch to fix bug > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88931. In the test case > > of the bug, the "#pragma STDC FENV_ACCESS ON" is used and t

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Joseph Myers
On Tue, 22 Jan 2019, Terry Guo wrote: > Hi Joseph, > > I believe HJ is proposing patch to fix bug > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88931. In the test case > of the bug, the "#pragma STDC FENV_ACCESS ON" is used and there are Which isn't supported by GCC. Any test involving roundin

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Terry Guo
On Tue, Jan 22, 2019 at 7:48 AM Joseph Myers wrote: > > On Mon, 21 Jan 2019, H.J. Lu wrote: > > > TI->SF and TI->DF conversions in libgcc2.c: > > > > FSTYPE > > FUNC (DWtype u) > > { > > ... > > } > > > > have no rounding mode support. We should replace __floattisf, __floattidf, > > __floatunti

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Joseph Myers
On Mon, 21 Jan 2019, H.J. Lu wrote: > TI->SF and TI->DF conversions in libgcc2.c: > > FSTYPE > FUNC (DWtype u) > { > ... > } > > have no rounding mode support. We should replace __floattisf, __floattidf, > __floatuntisf and __floatuntidf in libgcc2.c with these from soft-fp. Please explain w

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 9:09 AM H.J. Lu wrote: > > On Mon, Jan 21, 2019 at 8:59 AM Uros Bizjak wrote: > > > > On Mon, Jan 21, 2019 at 5:56 PM H.J. Lu wrote: > > > > > > On Mon, Jan 21, 2019 at 8:43 AM Uros Bizjak wrote: > > > > > > > > On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > > > > >

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 8:59 AM Uros Bizjak wrote: > > On Mon, Jan 21, 2019 at 5:56 PM H.J. Lu wrote: > > > > On Mon, Jan 21, 2019 at 8:43 AM Uros Bizjak wrote: > > > > > > On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > > > > > > > TI->SF and TI->DF conversions in libgcc2.c: > > > > > > > >

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Uros Bizjak
On Mon, Jan 21, 2019 at 5:56 PM H.J. Lu wrote: > > On Mon, Jan 21, 2019 at 8:43 AM Uros Bizjak wrote: > > > > On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > > > > > TI->SF and TI->DF conversions in libgcc2.c: > > > > > > FSTYPE > > > FUNC (DWtype u) > > > { > > > ... > > > } > > > > > > ha

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 8:43 AM Uros Bizjak wrote: > > On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > > > TI->SF and TI->DF conversions in libgcc2.c: > > > > FSTYPE > > FUNC (DWtype u) > > { > > ... > > } > > > > have no rounding mode support. We should replace __floattisf, __floattidf, >

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Uros Bizjak
On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > TI->SF and TI->DF conversions in libgcc2.c: > > FSTYPE > FUNC (DWtype u) > { > ... > } > > have no rounding mode support. We should replace __floattisf, __floattidf, > __floatuntisf and __floatuntidf in libgcc2.c with these from soft-fp. > >

[PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
TI->SF and TI->DF conversions in libgcc2.c: FSTYPE FUNC (DWtype u) { ... } have no rounding mode support. We should replace __floattisf, __floattidf, __floatuntisf and __floatuntidf in libgcc2.c with these from soft-fp. PR libgcc/88931 * config/i386/64/t-softfp-compat (libgcc2